Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ubuntu 22.04 on Github Actions #2451

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

wasifhossain
Copy link
Member

@wasifhossain wasifhossain commented Aug 14, 2023

Purpose

Check if tests can run on Github Actions. Currently it's failing as we can see here: https://github.com/rails-api/active_model_serializers/actions/runs/5841080668?pr=2450

Changes

Upgrade Ubuntu from 18.04 (deprecated) to 22.04 (latest). Also add test matrix for Ruby 3.2 and Rails 7.0

Caveats

Related GitHub issues

#2450

Additional helpful information

  • rubocop upgraded to v1 in order to pass tests
  • 2 rubocop files: rubocop_v0 would apply for Ruby < 3. otherwise rubocop_v1
  • .rubocop_v0.yml is merely holding changes from .rubocop.yml.
  • rubocop_v1 targets Ruby 3.0
  • rubocop_v1.yml is a superset of rubocop_v0.yml. Many new linters have been disabled on v1 in order to keep this PR simple. Ideally we should bring back those cops along with necessary code adjustments in future PR

@wasifhossain wasifhossain requested a review from bf4 September 15, 2023 10:36
@bf4 bf4 merged commit 2ae640f into 0-10-stable Oct 5, 2023
@bf4 bf4 deleted the upgrade-ubuntu-on-CI branch October 5, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants