Lookup fieldset using either string or symbol

rails-api · Jul 17, 2019 · 2581fe0 · 2581fe0
1 parent 433c0c6
commit 2581fe0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/active_model_serializers.gemspec b/active_model_serializers.gemspec
@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/rails-api/active_model_serializers'
   spec.license       = 'MIT'
 
-  spec.files         = Dir["CHANGELOG.md", "MIT-LICENSE", "README.md", "lib/**/*"]
+  spec.files         = Dir['CHANGELOG.md', 'MIT-LICENSE', 'README.md', 'lib/**/*']
   spec.require_paths = ['lib']
   spec.executables   = []
 

diff --git a/lib/active_model/serializer/fieldset.rb b/lib/active_model/serializer/fieldset.rb
@@ -12,7 +12,7 @@ def fields
       end
 
       def fields_for(type)
-        fields[type.singularize.to_sym] || fields[type.pluralize.to_sym]
+        fields[type.to_s.singularize.to_sym] || fields[type.to_s.pluralize.to_sym]
       end
 
       protected

diff --git a/test/serializers/fieldset_test.rb b/test/serializers/fieldset_test.rb
@@ -5,11 +5,21 @@
 module ActiveModel
   class Serializer
     class FieldsetTest < ActiveSupport::TestCase
+      def setup
+        @fieldset = ActiveModel::Serializer::Fieldset.new('post' => %w(id title), 'comment' => ['body'])
+      end
+
       def test_fieldset_with_hash
-        fieldset = ActiveModel::Serializer::Fieldset.new('post' => %w(id title), 'comment' => ['body'])
         expected = { post: [:id, :title], comment: [:body] }
 
-        assert_equal(expected, fieldset.fields)
+        assert_equal(expected, @fieldset.fields)
+      end
+
+      def test_fields_for_accepts_string_or_symbol
+        expected = [:id, :title]
+
+        assert_equal(expected, @fieldset.fields_for(:post))
+        assert_equal(expected, @fieldset.fields_for('post'))
       end
     end
   end