Make closeChannel callable by anybody with sigs #1124
Conversation
|
This is a part of #1123. |
On this commit pytest runs successfully. Lint does not work, and some function names sound wrong.
pirapira
force-pushed
the
close-channel-by-anybody
branch
from
f800426 to
b1d18d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
======================================
Coverage 81% 81%
======================================
Files 21 21
Lines 1411 1411
Branches 179 179
======================================
Hits 1143 1143
Misses 228 228
Partials 40 40Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
======================================
Coverage 81% 81%
======================================
Files 21 21
Lines 1411 1411
Branches 179 179
======================================
Hits 1143 1143
Misses 228 228
Partials 40 40Continue to review full report at Codecov.
|
|
Yay! |
|
|
||
| // This is the block number at which the channel can be settled. | ||
| channel.settle_block_number += uint256(block.number); | ||
|
|
||
| // The closing participant must have signed the balance proof. | ||
| address recovered_closing_participant_address = recoverAddressFromBalanceProofCounterSignature( |
There was a problem hiding this comment.
@pirapira: This uses MessageTypeId.BalanceProofUpdate. Shouldn't we use MessageTypeId.BalanceProof, instead?
There was a problem hiding this comment.
You're right because these are two different messages. I'll file a PR (it's a bug fix, not a new feature).
This follows the implementation change made in raiden-network/raiden-contracts#1124 Now that anybody can call closeChannel() on behalf of the closing party, the call now takes a signature of the closing party.
On this commit pytest runs successfully. Lint does not work, and
some function names sound wrong.