Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header and git issue #160

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

AE-Hertz
Copy link
Contributor

@AE-Hertz AE-Hertz commented Nov 1, 2024

🚀 Pull Request

Description

Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.
🐛 Bug Report: fix the issue in header #156

Type of Change

  • Bug fix braking change

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

Screenshot 2024-11-01 185758
Screenshot 2024-11-02 101919

Copy link

vercel bot commented Nov 1, 2024

@AE-Hertz is attempting to deploy a commit to the rahulsainlll's projects Team on Vercel.

A member of the Team first needs to authorize it.

@AE-Hertz
Copy link
Contributor Author

AE-Hertz commented Nov 1, 2024

fixed the breaking issue with the page-header.tsx, check logs.

@Aarzookhunger
Copy link
Collaborator

@AE-Hertz add screenshot for the same in light mode as well.!

@Aarzookhunger Aarzookhunger added bug Something isn't working level2 Medium gssoc-ext labels Nov 1, 2024
@AE-Hertz
Copy link
Contributor Author

AE-Hertz commented Nov 2, 2024

@Aarzookhunger yes, i have added, have a look.

@Aarzookhunger Aarzookhunger merged commit ae25f06 into rahulsainlll:main Nov 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level2 Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants