Fix: Correctly get alpnProtocol #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om http2, so that h2c works correctly.
|
@rahulramesha could you take a look when you get a chance? Thanks! |
sobolewsk
reviewed
Oct 12, 2023
|
|
||
| //Checking alpnProtocol for http2 | ||
| if (socket.alpnProtocol && (socket.alpnProtocol === 'h2' || socket.alpnProtocol === 'h2c')) { | ||
| if (alpnProtocol === 'h2' || alpnProtocol === 'h2c') { |
There was a problem hiding this comment.
I don't think checking alpnProtocol is needed here. Checking httpVersion should be sufficient.
mctrafik
approved these changes
Jan 15, 2024
|
@rahulramesha ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for insecure createServer imported from http2, so that h2c works correctly.
Old code was causing the protocol to return null when createServer was used.
New code works in node 16 for both createServer and createSecureServer