Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2: Problems in initialise statement (Solved) #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pprabh2007
Copy link

@pprabh2007 pprabh2007 commented Dec 11, 2018

Proposed Changes

Solution to issue #12. I have done my work in a separate function called variable_line, so that all the further additions on this aspect can be easily done, while maintaining the modularity of the code.

Types of Changes

Bug Fix

Summary of Changes

Added a new function called "variable_line", which handles all the bugs related to initialise statements we had discussed about.

Please describe the changes you have made, be as descriptive as you can

Earlier, the indices involving the elements such as variable type, variable identifier and value stored in the variable were hard-coded, due to which the code was quite vulnerable to minor changes in spacing.

Thus, statements such as:

initialise int a=32
initialise b=10.0

would work, whereas statements such as:

initialise int a = 32
initialise b= 10.0

will not work.

The purpose of this Pull Request is solely to solve this issue by making the process very less hard-coded.

If you fixed any bug , Please add screenshots/gifs of the modifications you have done

Please refer to the screenshots I have uploaded for demonstration on the page related to issue #12.
Both the pre-modification and post-modification have been uploaded there for demonstration purposes

If you have added any new feature please add screenshot of the output, how it has been changed after addition of the new feature

.. NA

Checklist

Please checkout the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask .Join our gitter channel and feel free to ask.

  • I have read the Contribution GuideLines.

  • Any dependent changes have been merged and published in downstream modules.

Thank You !

@pprabh2007
Copy link
Author

I have not added 'char' functionality as of now, as you suggested to make changes to only one feature at a time. On a side note, I have it ready with me. Will do it once you approve of this.

Hope you like it.

Thanks and regards,
Prabhpreet

@pprabh2007 pprabh2007 changed the title Add files via upload Issue #2: Problems in initialise statement (Solved) Dec 11, 2018
@pprabh2007
Copy link
Author

There was a confilict with base branch.. I have resolved it.. Please see to it

@pprabh2007
Copy link
Author

Any feedback?

Copy link
Contributor

@sumanthd17 sumanthd17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually solves the problem of multiple spaces between variable, '=' and the value assigned to it. Can be merged. It's good way to write clean code without actually depending on the user to write it based on our need.

@pprabh2007
Copy link
Author

Any updates or feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants