-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Standardise cf standards and missingval handling #695
Open
rafaqz
wants to merge
27
commits into
main
Choose a base branch
from
cf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ec02fd1
start adding cf keyword
rafaqz 5f7bed4
add modifieddiskarray file
rafaqz 8be3f25
use scale and offset keywords
rafaqz ded3eeb
bugfix
rafaqz 9e6019c
bugfix
rafaqz 53e167b
Merge branch 'main' into cf
rafaqz afe7920
updates
rafaqz 967083c
create
rafaqz c8a3828
tweaks
rafaqz 7a87d81
bugfixes
rafaqz a7d9b19
bugfix GRIB
rafaqz ee50b63
bugfixes
rafaqz 1a0c0d6
add raw keyword
rafaqz ce3b152
clean up extensions
rafaqz 329e92e
updates
rafaqz 981dd69
mosaic fixes and standardisation
rafaqz b7e63f2
bugfixes
rafaqz 1c20275
closured in create
rafaqz 53b16e3
Merge branch 'main' into cf
rafaqz a034c60
bugfixes
rafaqz 54056cb
fix resample test for nokw
rafaqz 6a57727
test create with a function
rafaqz 8500e42
Apply suggestions from code review
rafaqz c225840
Hook up scale and offset to Zarr datasets via CDM (#732)
asinghvi17 cfa1b95
use coalesceval instead of maskingval
rafaqz 3d975e9
merge changes
rafaqz 5f9be64
combine missingval and maskingval
rafaqz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,4 +51,4 @@ Or convert them to a `DataFrame`: | |
using DataFrames | ||
df = DataFrame(predictors) | ||
df[1:5,:] | ||
```` | ||
```` |
20 changes: 20 additions & 0 deletions
20
ext/GeometryOpsDimensionalDataExt/GeometryOpsDimensionalDataExt.jl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module GeometryOpsDimensionalDataExt | ||
|
||
import DimensionalData as DD | ||
import GeometryOps as GO | ||
import GeoInterface as GI | ||
|
||
function GO.polygonize(A::DD.AbstractDimArray; dims=(DD.X(), DD.Y()), crs=GI.crs(A), kw...) | ||
lookups = DD.lookup(A, dims) | ||
bounds_vecs = if DD.isintervals(lookups) | ||
map(DD.intervalbounds, lookups) | ||
else | ||
@warn "`polygonsize` is not possible for `Points` sampling, as polygons cover space by definition. Treating as `Intervals`, but this may not be appropriate" | ||
map(lookups) do l | ||
Dd.intervalbounds(DD.set(l, DD.Intervals())) | ||
end | ||
end | ||
GO.polygonize(bounds_vecs..., DD.AbstractDimArray; crs, kw...) | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we close the PR that does this in GeometryOps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I must have added that by mistake lol