Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly bug #665

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix nightly bug #665

merged 1 commit into from
Mar 11, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Mar 10, 2024

Closes #664

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.30%. Comparing base (55e8ecf) to head (b2bdf7f).

Files Patch % Lines
src/array/indexing.jl 80.00% 1 Missing ⚠️
src/stack/indexing.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   83.29%   83.30%   +0.01%     
==========================================
  Files          46       46              
  Lines        4191     4194       +3     
==========================================
+ Hits         3491     3494       +3     
  Misses        700      700              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz
Copy link
Owner Author

rafaqz commented Mar 11, 2024

@odow hopefully this is enough, the printing bug looks like a range/date bug in Base.

@rafaqz rafaqz merged commit be412a1 into main Mar 11, 2024
6 of 7 checks passed
@rafaqz rafaqz deleted the fix_nightly_bug branch March 11, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing on nightly because uses private methods from Base
1 participant