Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for NullPointerException #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix for NullPointerException #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4b9ca3
add failure callback for TelephonyModule
taliasegev Apr 16, 2018
1f906dd
2.0.0
taliasegev Apr 16, 2018
0adfc61
add try catch around telephonyManager addListener
taliasegev May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
324 changes: 173 additions & 151 deletions android/app/src/main/java/com/telephony/TelephonyModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,137 +96,151 @@ private void sendEvent(String eventName, Object params) {

@ReactMethod
public void startListener(int events) {
telephonyPhoneStateListener = new TelephonyListener(this);
telephonyManager.listen(telephonyPhoneStateListener, events);

try {
telephonyPhoneStateListener = new TelephonyListener(this);
if (telephonyManager != null) {
telephonyManager.listen(telephonyPhoneStateListener, events);
}
} catch (Exception e) {}
}

@ReactMethod
public void stopListener() {
telephonyManager.listen(telephonyPhoneStateListener,
PhoneStateListener.LISTEN_NONE);
telephonyManager = null;
telephonyPhoneStateListener = null;
try {
if (telephonyManager != null) {
telephonyManager.listen(telephonyPhoneStateListener,
PhoneStateListener.LISTEN_NONE);
telephonyManager = null;
}
telephonyPhoneStateListener = null;
} catch (Exception e) {}
}

@ReactMethod
public void isNetworkRoaming(Callback successCallback) {
public void isNetworkRoaming(Callback successCallback, Callback failureCallback) {
if (telephonyManager == null) {
failureCallback.invoke("telephonyManager is null");
return;
}
successCallback.invoke(telephonyManager.isNetworkRoaming());
}

@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR1)
@ReactMethod
public void getCellInfo(Callback successCallback) {

WritableArray mapArray = Arguments.createArray();
public void getCellInfo(Callback successCallback, Callback failureCallback) {
try {
WritableArray mapArray = Arguments.createArray();

List<CellInfo> cellInfo = telephonyManager.getAllCellInfo();

if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN_MR1 || cellInfo == null) {
successCallback.invoke(mapArray);
return;
}

int i = 0;
List<CellInfo> cellInfo = telephonyManager.getAllCellInfo();

for (CellInfo info : cellInfo) {
WritableMap mapCellIdentity = Arguments.createMap();
WritableMap mapCellSignalStrength = Arguments.createMap();
WritableMap map = Arguments.createMap();

map.putInt("key", i);

if (info instanceof CellInfoGsm) {
CellIdentityGsm cellIdentity = ((CellInfoGsm) info).getCellIdentity();
map.putString("connectionType", "GSM");

mapCellIdentity.putInt("cid", cellIdentity.getCid());
mapCellIdentity.putInt("lac", cellIdentity.getLac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("psc", cellIdentity.getPsc());

CellSignalStrengthGsm cellSignalStrengthGsm = ((CellInfoGsm) info).getCellSignalStrength();
mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthGsm.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthGsm.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthGsm.getLevel());
} else if (info instanceof CellInfoWcdma && android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
CellIdentityWcdma cellIdentity = ((CellInfoWcdma) info).getCellIdentity();
map.putString("connectionType", "WCDMA");

mapCellIdentity.putInt("cid", cellIdentity.getCid());
mapCellIdentity.putInt("lac", cellIdentity.getLac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("psc", cellIdentity.getPsc());

CellSignalStrengthWcdma cellSignalStrengthWcdma = ((CellInfoWcdma) info).getCellSignalStrength();
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN_MR1 || cellInfo == null) {
successCallback.invoke(mapArray);
return;
}

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthWcdma.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthWcdma.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthWcdma.getLevel());
} else if (info instanceof CellInfoLte) {
if(info.isRegistered()) {
mapCellIdentity.putBoolean("servingCellFlag", info.isRegistered());
} else {
mapCellIdentity.putBoolean("servingCellFlag", info.isRegistered());
int i = 0;

for (CellInfo info : cellInfo) {
WritableMap mapCellIdentity = Arguments.createMap();
WritableMap mapCellSignalStrength = Arguments.createMap();
WritableMap map = Arguments.createMap();

map.putInt("key", i);

if (info instanceof CellInfoGsm) {
CellIdentityGsm cellIdentity = ((CellInfoGsm) info).getCellIdentity();
map.putString("connectionType", "GSM");

mapCellIdentity.putInt("cid", cellIdentity.getCid());
mapCellIdentity.putInt("lac", cellIdentity.getLac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("psc", cellIdentity.getPsc());

CellSignalStrengthGsm cellSignalStrengthGsm = ((CellInfoGsm) info).getCellSignalStrength();
mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthGsm.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthGsm.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthGsm.getLevel());
} else if (info instanceof CellInfoWcdma && android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
CellIdentityWcdma cellIdentity = ((CellInfoWcdma) info).getCellIdentity();
map.putString("connectionType", "WCDMA");

mapCellIdentity.putInt("cid", cellIdentity.getCid());
mapCellIdentity.putInt("lac", cellIdentity.getLac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("psc", cellIdentity.getPsc());

CellSignalStrengthWcdma cellSignalStrengthWcdma = ((CellInfoWcdma) info).getCellSignalStrength();

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthWcdma.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthWcdma.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthWcdma.getLevel());
} else if (info instanceof CellInfoLte) {
if (info.isRegistered()) {
mapCellIdentity.putBoolean("servingCellFlag", info.isRegistered());
} else {
mapCellIdentity.putBoolean("servingCellFlag", info.isRegistered());
}
CellIdentityLte cellIdentity = ((CellInfoLte) info).getCellIdentity();
map.putString("connectionType", "LTE");

mapCellIdentity.putInt("cid", cellIdentity.getCi());
mapCellIdentity.putInt("tac", cellIdentity.getTac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("pci", cellIdentity.getPci());
getEarfcn(mapCellIdentity, cellIdentity);

String cellIdHex = decToHex(cellIdentity.getCi());
boolean cellIdHexIsEmpty = cellIdHex == null || cellIdHex.isEmpty() || cellIdHex.length() < 2;
String eNodeBHex = cellIdHexIsEmpty ? "0" : cellIdHex.substring(0, cellIdHex.length() - 2);
mapCellIdentity.putInt("eNodeB", hexToDec(eNodeBHex));
String localCellIdHex = cellIdHexIsEmpty ? "0" : cellIdHex.substring(cellIdHex.length() - 2, cellIdHex.length());
mapCellIdentity.putInt("localCellId", hexToDec(localCellIdHex));

CellSignalStrengthLte cellSignalStrengthLte = ((CellInfoLte) info).getCellSignalStrength();

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthLte.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthLte.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthLte.getLevel());
mapCellSignalStrength.putInt("timingAdvance", cellSignalStrengthLte.getTimingAdvance());

} else if (info instanceof CellInfoCdma) {
CellIdentityCdma cellIdentity = ((CellInfoCdma) info).getCellIdentity();
map.putString("connectionType", "CDMA");

mapCellIdentity.putInt("basestationId", cellIdentity.getBasestationId());
mapCellIdentity.putInt("latitude", cellIdentity.getLatitude());
mapCellIdentity.putInt("longitude", cellIdentity.getLongitude());
mapCellIdentity.putInt("networkId", cellIdentity.getNetworkId());
mapCellIdentity.putInt("systemId", cellIdentity.getSystemId());

CellSignalStrengthCdma cellSignalStrengthCdma = ((CellInfoCdma) info).getCellSignalStrength();

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthCdma.getAsuLevel());
mapCellSignalStrength.putInt("cmdaDbm", cellSignalStrengthCdma.getCdmaDbm());
mapCellSignalStrength.putInt("cmdaEcio", cellSignalStrengthCdma.getCdmaEcio());
mapCellSignalStrength.putInt("cmdaLevl", cellSignalStrengthCdma.getCdmaLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthCdma.getDbm());
mapCellSignalStrength.putInt("evdoDbm", cellSignalStrengthCdma.getEvdoDbm());
mapCellSignalStrength.putInt("evdoEcio", cellSignalStrengthCdma.getEvdoEcio());
mapCellSignalStrength.putInt("evdoLevel", cellSignalStrengthCdma.getEvdoLevel());
mapCellSignalStrength.putInt("evdoSnr", cellSignalStrengthCdma.getEvdoSnr());
mapCellSignalStrength.putInt("level", cellSignalStrengthCdma.getLevel());
}
CellIdentityLte cellIdentity = ((CellInfoLte) info).getCellIdentity();
map.putString("connectionType", "LTE");

mapCellIdentity.putInt("cid", cellIdentity.getCi());
mapCellIdentity.putInt("tac", cellIdentity.getTac());
mapCellIdentity.putInt("mcc", cellIdentity.getMcc());
mapCellIdentity.putInt("mnc", cellIdentity.getMnc());
mapCellIdentity.putInt("pci", cellIdentity.getPci());
getEarfcn(mapCellIdentity, cellIdentity);

String cellIdHex = decToHex(cellIdentity.getCi());
boolean cellIdHexIsEmpty = cellIdHex == null || cellIdHex.isEmpty() || cellIdHex.length() < 2;
String eNodeBHex = cellIdHexIsEmpty ? "0" : cellIdHex.substring(0, cellIdHex.length() - 2);
mapCellIdentity.putInt("eNodeB", hexToDec(eNodeBHex));
String localCellIdHex = cellIdHexIsEmpty ? "0" : cellIdHex.substring(cellIdHex.length() - 2, cellIdHex.length());
mapCellIdentity.putInt("localCellId", hexToDec(localCellIdHex));

CellSignalStrengthLte cellSignalStrengthLte = ((CellInfoLte) info).getCellSignalStrength();

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthLte.getAsuLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthLte.getDbm());
mapCellSignalStrength.putInt("level", cellSignalStrengthLte.getLevel());
mapCellSignalStrength.putInt("timingAdvance", cellSignalStrengthLte.getTimingAdvance());

} else if (info instanceof CellInfoCdma) {
CellIdentityCdma cellIdentity = ((CellInfoCdma) info).getCellIdentity();
map.putString("connectionType", "CDMA");

mapCellIdentity.putInt("basestationId", cellIdentity.getBasestationId());
mapCellIdentity.putInt("latitude", cellIdentity.getLatitude());
mapCellIdentity.putInt("longitude", cellIdentity.getLongitude());
mapCellIdentity.putInt("networkId", cellIdentity.getNetworkId());
mapCellIdentity.putInt("systemId", cellIdentity.getSystemId());

CellSignalStrengthCdma cellSignalStrengthCdma = ((CellInfoCdma) info).getCellSignalStrength();
map.putMap("cellIdentity", mapCellIdentity);
map.putMap("cellSignalStrength", mapCellSignalStrength);

mapCellSignalStrength.putInt("asuLevel", cellSignalStrengthCdma.getAsuLevel());
mapCellSignalStrength.putInt("cmdaDbm", cellSignalStrengthCdma.getCdmaDbm());
mapCellSignalStrength.putInt("cmdaEcio", cellSignalStrengthCdma.getCdmaEcio());
mapCellSignalStrength.putInt("cmdaLevl", cellSignalStrengthCdma.getCdmaLevel());
mapCellSignalStrength.putInt("dBm", cellSignalStrengthCdma.getDbm());
mapCellSignalStrength.putInt("evdoDbm", cellSignalStrengthCdma.getEvdoDbm());
mapCellSignalStrength.putInt("evdoEcio", cellSignalStrengthCdma.getEvdoEcio());
mapCellSignalStrength.putInt("evdoLevel", cellSignalStrengthCdma.getEvdoLevel());
mapCellSignalStrength.putInt("evdoSnr", cellSignalStrengthCdma.getEvdoSnr());
mapCellSignalStrength.putInt("level", cellSignalStrengthCdma.getLevel());
mapArray.pushMap(map);
i++;
}

map.putMap("cellIdentity", mapCellIdentity);
map.putMap("cellSignalStrength", mapCellSignalStrength);

mapArray.pushMap(map);
i++;
successCallback.invoke(mapArray);
} catch (Exception e) {
failureCallback.invoke(e.getMessage());
}

successCallback.invoke(mapArray);
}

@TargetApi(24)
Expand All @@ -241,51 +255,59 @@ public void getEarfcn(WritableMap mapCellIdentity, CellIdentityLte cellIdentity)
}

@ReactMethod
public void getPhoneInfo(Callback successCallBack) {
WritableMap mapPhoneInfo = Arguments.createMap();

mapPhoneInfo.putString("imsi", telephonyManager.getSubscriberId().toString());
mapPhoneInfo.putString("imei", telephonyManager.getDeviceId());
mapPhoneInfo.putString("mdn", telephonyManager.getLine1Number());
mapPhoneInfo.putString("model", Build.MANUFACTURER
+ " " + Build.MODEL + " " + Build.VERSION.RELEASE
+ " " + Build.VERSION_CODES.class.getFields()[Build.VERSION.SDK_INT].getName());
successCallBack.invoke(mapPhoneInfo);
public void getPhoneInfo(Callback successCallBack, Callback failureCallback) {
try {
WritableMap mapPhoneInfo = Arguments.createMap();

mapPhoneInfo.putString("imsi", telephonyManager.getSubscriberId().toString());
mapPhoneInfo.putString("imei", telephonyManager.getDeviceId());
mapPhoneInfo.putString("mdn", telephonyManager.getLine1Number());
mapPhoneInfo.putString("model", Build.MANUFACTURER
+ " " + Build.MODEL + " " + Build.VERSION.RELEASE
+ " " + Build.VERSION_CODES.class.getFields()[Build.VERSION.SDK_INT].getName());
successCallBack.invoke(mapPhoneInfo);
} catch (Exception e) {
failureCallback.invoke(e.getMessage());
}
}

@ReactMethod
public void getNetworkClass(Callback successCallback) {
int networkType = telephonyManager.getNetworkType();
String network;

switch (networkType) {
case TelephonyManager.NETWORK_TYPE_GPRS:
case TelephonyManager.NETWORK_TYPE_EDGE:
case TelephonyManager.NETWORK_TYPE_CDMA:
case TelephonyManager.NETWORK_TYPE_1xRTT:
case TelephonyManager.NETWORK_TYPE_IDEN:
network = "2G";
break;
case TelephonyManager.NETWORK_TYPE_UMTS:
case TelephonyManager.NETWORK_TYPE_EVDO_0:
case TelephonyManager.NETWORK_TYPE_EVDO_A:
case TelephonyManager.NETWORK_TYPE_HSDPA:
case TelephonyManager.NETWORK_TYPE_HSUPA:
case TelephonyManager.NETWORK_TYPE_HSPA:
case TelephonyManager.NETWORK_TYPE_EVDO_B:
case TelephonyManager.NETWORK_TYPE_EHRPD:
case TelephonyManager.NETWORK_TYPE_HSPAP:
network = "3G";
break;
case TelephonyManager.NETWORK_TYPE_LTE:
network = "4G";
break;
default:
network = "Unknown";
break;
}
public void getNetworkClass(Callback successCallback, Callback failureCallback) {
try {
int networkType = telephonyManager.getNetworkType();
String network;

switch (networkType) {
case TelephonyManager.NETWORK_TYPE_GPRS:
case TelephonyManager.NETWORK_TYPE_EDGE:
case TelephonyManager.NETWORK_TYPE_CDMA:
case TelephonyManager.NETWORK_TYPE_1xRTT:
case TelephonyManager.NETWORK_TYPE_IDEN:
network = "2G";
break;
case TelephonyManager.NETWORK_TYPE_UMTS:
case TelephonyManager.NETWORK_TYPE_EVDO_0:
case TelephonyManager.NETWORK_TYPE_EVDO_A:
case TelephonyManager.NETWORK_TYPE_HSDPA:
case TelephonyManager.NETWORK_TYPE_HSUPA:
case TelephonyManager.NETWORK_TYPE_HSPA:
case TelephonyManager.NETWORK_TYPE_EVDO_B:
case TelephonyManager.NETWORK_TYPE_EHRPD:
case TelephonyManager.NETWORK_TYPE_HSPAP:
network = "3G";
break;
case TelephonyManager.NETWORK_TYPE_LTE:
network = "4G";
break;
default:
network = "Unknown";
break;
}

successCallback.invoke(network);
successCallback.invoke(network);
} catch (Exception e) {
failureCallback.invoke(e.getMessage());
}
}

@Override
Expand Down
Loading