Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Add webhook check for sidecar image #731

Merged
merged 2 commits into from
Nov 2, 2022
Merged

api: Add webhook check for sidecar image #731

merged 2 commits into from
Nov 2, 2022

Conversation

zhl003
Copy link
Collaborator

@zhl003 zhl003 commented Nov 2, 2022 •
edited
Loading

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #727 #726

What this PR does?

Summary:

Special notes for your reviewer?

kubectl edit mysql sample 
error: mysqlclusters.mysql.radondb.com "sample" could not be patched: admission webhook "vmysqlcluster.kb.io" denied the request: forbidden: spec.MysqlVersion is 5.7, but spec.PodPolicy.SidecarImage is not 5.7
You can run `kubectl replace -f /tmp/kubectl-edit-3934028760.yaml` to try this update again.

@zhl003 zhl003 added the enhancement New feature or request label Nov 2, 2022
@zhl003 zhl003 self-assigned this Nov 2, 2022
acekingke
acekingke approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@acekingke acekingke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhl003 zhl003 merged commit 8b3969c into radondb:main Nov 2, 2022
@qianfen2021 qianfen2021 added this to the v2.3.0 milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acekingke acekingke acekingke approved these changes

@qianfen2021 qianfen2021 Awaiting requested review from qianfen2021

Assignees

@zhl003 zhl003

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

check sidecarImage、mysqlVersion stay the same
3 participants
@zhl003 @acekingke @qianfen2021