Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scrypto install script debug logging #2033

Merged

Conversation

azizi-a
Copy link
Contributor

@azizi-a azizi-a commented Dec 3, 2024

Summary

Removed debug param that was logging all install script lines on macOS

Testing

Manually tested updated script

@azizi-a azizi-a requested a review from iamyulong December 3, 2024 08:36
Copy link

github-actions bot commented Dec 3, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:c3070d4c1d

Copy link

github-actions bot commented Dec 3, 2024

Benchmark for c3070d4

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.6±0.16ms 44.6±0.22ms 0.00%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.04ms 19.6±0.03ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 41.3±0.15ms 42.0±0.14ms +1.69%
costing::decode_encoded_tuple_array_to_manifest_raw_value 71.3±0.06ms 71.3±0.13ms 0.00%
costing::decode_encoded_tuple_array_to_manifest_value 103.3±0.43ms 121.6±1.21ms +17.72%
costing::decode_encoded_u8_array_to_manifest_raw_value 28.0±0.03µs 32.3±0.07µs +15.36%
costing::decode_encoded_u8_array_to_manifest_value 41.2±0.17ms 41.7±0.17ms +1.21%
costing::decode_rpd_to_manifest_raw_value 14.7±0.03µs 14.7±0.02µs 0.00%
costing::decode_rpd_to_manifest_value 10.8±0.03µs 10.8±0.06µs 0.00%
costing::deserialize_wasm 1209.5±10.20µs 1211.7±5.51µs +0.18%
costing::execute_transaction_creating_big_vec_substates 692.5±8.94ms 698.6±9.16ms +0.88%
costing::execute_transaction_reading_big_vec_substates 586.7±1.92ms 589.9±2.70ms +0.55%
costing::instantiate_flash_loan 868.4±374.57µs 1035.7±1388.91µs +19.27%
costing::instantiate_radiswap 1029.8±1438.41µs 935.1±899.71µs -9.20%
costing::scrypto_malloc 666.6±1.36ms 662.6±1.04ms -0.60%
costing::scrypto_sbor_decode 663.5±1.09ms 659.6±2.22ms -0.59%
costing::scrypto_sha256 583.8±2.79ms 580.6±0.97ms -0.55%
costing::spin_loop_v1 508.3±1.11ms 507.2±1.20ms -0.22%
costing::spin_loop_v2 597.9±7.37ms 605.1±0.32ms +1.20%
costing::validate_sbor_payload 29.5±0.06µs 29.5±0.06µs 0.00%
costing::validate_sbor_payload_bytes 248.1±0.71ns 252.1±0.90ns +1.61%
costing::validate_secp256k1 76.6±0.27µs 76.6±0.10µs 0.00%
costing::validate_wasm 34.0±0.04ms 33.4±0.04ms -1.76%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 311.2±2.43ns 310.2±2.84ns -0.32%
decimal::add/wasmi-call-native 2.9±0.00µs 2.9±0.00µs 0.00%
decimal::div/0 173.9±0.16ns 168.3±0.17ns -3.22%
decimal::from_string/0 166.4±0.13ns 157.1±0.11ns -5.59%
decimal::mul/0 126.6±0.05ns 129.9±0.66ns +2.61%
decimal::mul/rust-native 128.4±0.05ns 128.4±0.06ns 0.00%
decimal::mul/wasmi 19.4±0.05µs 19.7±0.07µs +1.55%
decimal::mul/wasmi-call-native 3.1±0.00µs 3.1±0.00µs 0.00%
decimal::pow/0 592.6±0.95ns 591.4±0.25ns -0.20%
decimal::pow/rust-native 593.7±0.52ns 591.7±0.64ns -0.34%
decimal::pow/wasmi 91.6±0.25µs 92.4±0.30µs +0.87%
decimal::pow/wasmi-call-native 4.8±0.00µs 4.9±0.01µs +2.08%
decimal::root/0 8.0±0.00µs 8.1±0.04µs +1.25%
decimal::sub/0 8.2±0.07ns 8.2±0.01ns 0.00%
decimal::to_string/0 441.2±0.26ns 444.8±0.69ns +0.82%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.1±0.01ms 6.2±0.02ms +1.64%
large_transaction_processing::prepare_and_decompile_and_recompile 25.4±0.07ms 24.4±0.08ms -3.94%
metadata_validation::validate_urls 5.1±0.03µs 5.2±0.02µs +1.96%
precise_decimal::add/0 8.7±0.07ns 8.9±0.02ns +2.30%
precise_decimal::add/rust-native 10.7±0.21ns 10.7±0.07ns 0.00%
precise_decimal::add/wasmi 412.8±2.72ns 416.0±3.00ns +0.78%
precise_decimal::add/wasmi-call-native 3.8±0.01µs 3.8±0.01µs 0.00%
precise_decimal::div/0 301.4±2.87ns 294.3±0.44ns -2.36%
precise_decimal::from_string/0 201.0±0.18ns 201.5±0.34ns +0.25%
precise_decimal::mul/0 332.3±0.68ns 332.3±0.32ns 0.00%
precise_decimal::mul/rust-native 299.6±1.27ns 300.8±1.92ns +0.40%
precise_decimal::mul/wasmi 49.0±0.16µs 49.3±0.10µs +0.61%
precise_decimal::mul/wasmi-call-native 4.2±0.00µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1722.0±2.18ns 1728.6±2.34ns +0.38%
precise_decimal::pow/rust-native 1355.8±1.29ns 1353.5±0.70ns -0.17%
precise_decimal::pow/wasmi 233.6±0.46µs 237.9±0.62µs +1.84%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.5±0.01µs 0.00%
precise_decimal::root/0 58.3±0.05µs 57.9±0.03µs -0.69%
precise_decimal::sub/0 9.0±0.04ns 9.2±0.11ns +2.22%
precise_decimal::to_string/0 716.0±0.67ns 692.5±0.73ns -3.28%
schema::validate_payload 382.2±0.49µs 386.7±0.38µs +1.18%
transaction::radiswap 5.0±0.03ms 5.0±0.02ms 0.00%
transaction::transfer 1815.7±2.90µs 1825.3±2.67µs +0.53%
transaction_validation::validate_manifest 43.0±0.05µs 43.0±0.05µs 0.00%
transaction_validation::verify_bls_2KB 971.2±14.08µs 971.5±12.60µs +0.03%
transaction_validation::verify_bls_32B 974.8±14.86µs 967.6±13.24µs -0.74%
transaction_validation::verify_ecdsa 74.6±1.26µs 74.4±0.05µs -0.27%
transaction_validation::verify_ed25519 42.3±0.19µs 42.2±0.06µs -0.24%

@azizi-a azizi-a merged commit 0ece872 into release/cuttlefish Dec 3, 2024
31 checks passed
@azizi-a azizi-a deleted the remove-scrypto-install-script-debug-logs branch December 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants