Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify parent #2006

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Fix verify parent #2006

merged 8 commits into from
Nov 20, 2024

Conversation

talekhinezh
Copy link
Member

No description provided.

@talekhinezh talekhinezh marked this pull request as ready for review November 19, 2024 19:46
Copy link

github-actions bot commented Nov 19, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:699bc60cee

Copy link

github-actions bot commented Nov 19, 2024

Benchmark for 699bc60

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 45.7±0.40ms 45.1±0.19ms -1.31%
costing::decode_encoded_i8_array_to_manifest_raw_value 20.2±0.39ms 19.5±0.05ms -3.47%
costing::decode_encoded_i8_array_to_manifest_value 41.1±0.21ms 41.6±0.07ms +1.22%
costing::decode_encoded_tuple_array_to_manifest_raw_value 61.4±0.37ms 61.2±0.17ms -0.33%
costing::decode_encoded_tuple_array_to_manifest_value 99.3±0.56ms 99.1±0.21ms -0.20%
costing::decode_encoded_u8_array_to_manifest_raw_value 33.2±0.23µs 32.3±0.10µs -2.71%
costing::decode_encoded_u8_array_to_manifest_value 40.8±0.27ms 41.6±0.08ms +1.96%
costing::decode_rpd_to_manifest_raw_value 13.0±0.09µs 12.8±0.07µs -1.54%
costing::decode_rpd_to_manifest_value 11.4±0.11µs 11.2±0.02µs -1.75%
costing::deserialize_wasm 1265.9±10.74µs 1219.6±3.86µs -3.66%
costing::execute_transaction_creating_big_vec_substates 689.3±6.06ms 696.4±10.10ms +1.03%
costing::execute_transaction_reading_big_vec_substates 586.2±2.56ms 589.9±3.12ms +0.63%
costing::instantiate_flash_loan 1006.9±1215.75µs 1004.7±1231.21µs -0.22%
costing::instantiate_radiswap 928.9±536.05µs 1020.0±1472.33µs +9.81%
costing::scrypto_malloc 700.0±4.04ms 695.7±1.99ms -0.61%
costing::scrypto_sbor_decode 680.9±2.12ms 675.6±2.83ms -0.78%
costing::scrypto_sha256 601.7±1.65ms 593.2±3.10ms -1.41%
costing::spin_loop_v1 518.5±3.54ms 516.5±2.18ms -0.39%
costing::spin_loop_v2 605.2±1.57ms 606.4±4.88ms +0.20%
costing::validate_sbor_payload 30.2±0.21µs 30.0±0.05µs -0.66%
costing::validate_sbor_payload_bytes 252.8±1.94ns 255.5±1.22ns +1.07%
costing::validate_secp256k1 77.0±0.59µs 76.5±0.05µs -0.65%
costing::validate_wasm 34.4±0.23ms 34.1±0.05ms -0.87%
decimal::add/0 8.5±0.06ns 8.4±0.00ns -1.18%
decimal::add/rust-native 9.9±0.05ns 9.8±0.00ns -1.01%
decimal::add/wasmi 318.4±3.17ns 318.6±2.81ns +0.06%
decimal::add/wasmi-call-native 3.0±0.02µs 3.1±0.00µs +3.33%
decimal::div/0 171.5±0.63ns 166.8±0.14ns -2.74%
decimal::from_string/0 158.8±0.59ns 156.7±0.13ns -1.32%
decimal::mul/0 128.0±0.92ns 126.6±0.07ns -1.09%
decimal::mul/rust-native 128.7±0.44ns 127.9±0.29ns -0.62%
decimal::mul/wasmi 19.6±0.09µs 19.3±0.07µs -1.53%
decimal::mul/wasmi-call-native 3.2±0.02µs 3.3±0.01µs +3.12%
decimal::pow/0 606.9±3.23ns 596.2±0.52ns -1.76%
decimal::pow/rust-native 601.3±3.01ns 589.8±0.49ns -1.91%
decimal::pow/wasmi 93.6±0.51µs 98.8±0.36µs +5.56%
decimal::pow/wasmi-call-native 5.0±0.03µs 4.9±0.01µs -2.00%
decimal::root/0 9.0±0.04µs 8.0±0.01µs -11.11%
decimal::sub/0 8.3±0.03ns 8.2±0.00ns -1.20%
decimal::to_string/0 450.7±2.15ns 444.7±0.22ns -1.33%
large_transaction_processing::prepare 2.6±0.01ms 2.6±0.02ms 0.00%
large_transaction_processing::prepare_and_decompile 6.2±0.05ms 6.3±0.05ms +1.61%
large_transaction_processing::prepare_and_decompile_and_recompile 32.1±0.20ms 31.0±1.40ms -3.43%
metadata_validation::validate_urls 5.2±0.04µs 4.8±0.06µs -7.69%
precise_decimal::add/0 9.1±0.02ns 8.7±0.03ns -4.40%
precise_decimal::add/rust-native 10.9±0.11ns 10.7±0.06ns -1.83%
precise_decimal::add/wasmi 424.3±3.48ns 420.4±5.34ns -0.92%
precise_decimal::add/wasmi-call-native 4.0±0.02µs 3.9±0.00µs -2.50%
precise_decimal::div/0 292.8±1.14ns 290.7±0.42ns -0.72%
precise_decimal::from_string/0 204.0±0.73ns 200.9±0.13ns -1.52%
precise_decimal::mul/0 337.2±2.18ns 332.0±0.67ns -1.54%
precise_decimal::mul/rust-native 290.4±0.88ns 286.5±0.44ns -1.34%
precise_decimal::mul/wasmi 48.5±0.21µs 48.4±0.14µs -0.21%
precise_decimal::mul/wasmi-call-native 4.3±0.02µs 4.3±0.00µs 0.00%
precise_decimal::pow/0 1806.3±8.58ns 1770.7±1.75ns -1.97%
precise_decimal::pow/rust-native 1364.8±5.58ns 1355.7±1.01ns -0.67%
precise_decimal::pow/wasmi 235.3±0.94µs 232.3±0.34µs -1.27%
precise_decimal::pow/wasmi-call-native 7.7±0.05µs 7.6±0.00µs -1.30%
precise_decimal::root/0 58.9±0.26µs 58.2±0.11µs -1.19%
precise_decimal::sub/0 9.3±0.05ns 9.0±0.18ns -3.23%
precise_decimal::to_string/0 711.3±3.97ns 702.8±1.42ns -1.19%
schema::validate_payload 387.0±2.52µs 378.9±0.31µs -2.09%
transaction::radiswap 5.0±0.03ms 5.0±0.04ms 0.00%
transaction::transfer 1835.2±8.26µs 1868.4±9.60µs +1.81%
transaction_validation::validate_manifest 43.3±0.27µs 43.8±0.50µs +1.15%
transaction_validation::verify_bls_2KB 1038.5±28.33µs 1053.5±28.02µs +1.44%
transaction_validation::verify_bls_32B 1070.7±15.14µs 1039.6±24.34µs -2.90%
transaction_validation::verify_ecdsa 75.8±0.44µs 75.7±0.56µs -0.13%
transaction_validation::verify_ed25519 43.2±0.21µs 43.1±0.28µs -0.23%

@iamyulong iamyulong merged commit 7511806 into release/cuttlefish Nov 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants