Add intent hash to the error code #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
Benchmark for b8167e8Click to view benchmark
|
dhedey
approved these changes
Oct 29, 2024
| @@ -540,7 +540,7 @@ impl<V: SystemCallbackObject> System<V> { | |||
|
|
|||
| fn validate_intent_hash_uncosted<S: CommitableSubstateStore>( | |||
There was a problem hiding this comment.
What were your thoughts on that drive-by refactor to deduplicate the read of TransactionTrackerField::TransactionTracker?
There was a problem hiding this comment.
My default position is always not to change unless there is a problem.
I'm not too sure if this will cause any performance issue as the duplicate reads will be from cache.
radix-engine/src/errors.rs
Outdated
| @@ -65,14 +66,17 @@ pub enum RejectionReason { | |||
| valid_to_exclusive: Instant, | |||
| current_time: Instant, | |||
| }, | |||
| IntentHashPreviouslyCommitted, | |||
| IntentHashPreviouslyCancelled, | |||
| DeprecatedIntentHashPreviouslyCommitted, | |||
There was a problem hiding this comment.
I guess if it's not in the LocalTransactionExecution / persisted in node; and we no longer serialize transaction receipts, then we don't actually need this to be maintained over time, and could remove these after all?
There was a problem hiding this comment.
That's my initial thought. I kept it just in case Gateway is serializing rejection reason somewhere. Happy to remove them if that's not the case.
This reverts commit 306e461.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds intent hash to the rejection error code, so clients can know whether transaction intent hash or subintent hash was failing.