Feature: Seconds Precision Timestamp Update #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for e07bf32Click to view benchmark
|
talekhinezh
force-pushed
the
feature/timestamp-seconds
branch
from
c0d6b57 to
869f37e
Compare
0xOmarA
approved these changes
Jan 10, 2024
| @@ -40,7 +40,7 @@ impl ShowLedger { | |||
| ) | |||
| .map_err(Error::IOError)?; | |||
|
|
|||
| let instant = Self::get_current_time(out, TimePrecision::Minute)?; | |||
| let instant = Self::get_current_time(out, TimePrecisionV1::Minute)?; | |||
There was a problem hiding this comment.
How about we make committing the state changes from generate_seconds_precision_state_updates part of the simulator's bootstrap process? This is not just important for people running the show-ledger command but for users who're relying on second precision and running their blueprints in the simulator.
There was a problem hiding this comment.
Hrm, was thinking of updating resim at a later PR so that users don't build against interfaces which don't exist on ledger yet but I think that might be fine so will implement your updates
There was a problem hiding this comment.
I think that if we plan on releasing a new version of Scrypto on the day of the protocol update then it would be fine if resim was updated.
There was a problem hiding this comment.
Running into some issues right now with getting this implemented. As discussed with @0xOmarA , he will create a follow-up PR fixing resim.
| @@ -222,7 +239,14 @@ pub const CONSENSUS_MANAGER_COMPARE_CURRENT_TIME_IDENT: &str = "compare_current_ | |||
| #[derive(Debug, Clone, Eq, PartialEq, ScryptoSbor)] | |||
| pub struct ConsensusManagerCompareCurrentTimeInput { | |||
There was a problem hiding this comment.
For consistency, can this be ConsensusManagerCompareCurrentTimeInputV1?
There was a problem hiding this comment.
Tried to use ConsensusManagerCompareCurrentTimeInputV1 but it's failing tests for some reason. Will come back to this in another PR.
There was a problem hiding this comment.
Also, as discussed with @0xOmarA , he will follow up with a cleanup PR on this.
talekhinezh
force-pushed
the
feature/timestamp-seconds
branch
2 times, most recently
from
98f42d0 to
f92f643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated logic of consensus manager methods to include seconds precision.
Added StateUpdates generator for substate flashing of the Seconds Precision Timestamp Update to be used with flash transactions.