-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radix-engine-tests reorganisation #1656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for fbc099fClick to view benchmark
|
mstrug-rdx
changed the title
Radix-engine-test reorganisation
Radix-engine-tests reorganisation
Nov 27, 2023
iamyulong
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
radix-engine-tests
project reorganisation.Details
tests
directory has been divided into subfolders basing on the execution layers: application, blueprints, system, vm, kernel, db. Files with tests has been moved to new subfolders basing on their content - but here still may be needed some adjustments.Changing flat file structure to subdirectory based improved compilation time from ~5min to less than 2min due to greatly reduced executables count.
Added library target with
common.rs
file which contains dedicated module with macros for handling file paths to the assets (workspace blueprints and wasm/rpd files and local blueprint and wat files), and also moved to this filepackage_loader
module (as it is commonly used by lots of tests). This library is used in integration tests and benches targets (everywhere where is an access to assets file paths), so changing asset paths in future will require change in only one place (common.rs
).Added
README.md
file with some descriptions on how to run the tests.