Chore: remove leftover consensus manager method

[malexandru-rdx]

Pure refactor/chore PR with no intended functional changes.

We no longer publicly expose update_validator (at that time in ConsensusManager), instead it is an internal/helper method. Here I remove the pub(crate) and the CONSENSUS_MANAGER_UPDATE_VALIDATOR_IDENT.

[github-actions]

Benchmark for e0730ce

Click to view benchmark

Test	Base	PR	%
costing::bench_prepare_wasm	76.3±0.33ms	76.1±0.45ms	-0.26%
costing::decode_sbor	16.7±0.07µs	16.8±0.09µs	+0.60%
costing::decode_sbor_bytes	58.4±0.10µs	46.5±0.31µs	-20.38%
costing::deserialize_wasm	1400.5±4.99µs	1379.5±4.21µs	-1.50%
costing::instantiate_flash_loan	4.6±0.64ms	4.6±0.98ms	0.00%
costing::instantiate_radiswap	7.1±0.09ms	6.8±0.15ms	-4.23%
costing::spin_loop	30.7±0.09ms	27.9±0.42ms	-9.12%
costing::validate_sbor_payload	30.6±0.09µs	30.2±0.04µs	-1.31%
costing::validate_sbor_payload_bytes	381.8±0.68ns	399.5±2.46ns	+4.64%
costing::validate_secp256k1	87.4±0.05µs	87.5±0.39µs	+0.11%
costing::validate_wasm	45.1±0.12ms	42.9±0.09ms	-4.88%
decimal::add/0	9.4±0.13ns	9.3±0.00ns	-1.06%
decimal::add/rust-native	10.9±0.00ns	10.9±0.01ns	0.00%
decimal::add/wasmer	128.4±0.40ns	128.6±0.20ns	+0.16%
decimal::add/wasmer-call-native	558.0±0.68ns	558.5±0.41ns	+0.09%
decimal::add/wasmi	810.4±3.37ns	853.3±4.03ns	+5.29%
decimal::add/wasmi-call-native	8.5±0.02µs	8.3±0.04µs	-2.35%
decimal::div/0	201.1±0.21ns	201.7±0.17ns	+0.30%
decimal::from_string/0	167.5±0.25ns	165.5±0.24ns	-1.19%
decimal::mul/0	155.8±0.45ns	157.2±0.31ns	+0.90%
decimal::mul/rust-native	160.8±0.42ns	149.9±0.30ns	-6.78%
decimal::mul/wasmer	1673.2±0.62ns	1694.7±23.19ns	+1.28%
decimal::mul/wasmer-call-native	708.5±0.51ns	709.5±2.59ns	+0.14%
decimal::mul/wasmi	61.2±0.08µs	60.9±0.08µs	-0.49%
decimal::mul/wasmi-call-native	8.6±0.01µs	8.4±0.02µs	-2.33%
decimal::pow/0	724.9±1.16ns	731.8±0.65ns	+0.95%
decimal::pow/rust-native	699.5±0.99ns	702.9±0.76ns	+0.49%
decimal::pow/wasmer	7.3±0.03µs	7.3±0.02µs	0.00%
decimal::pow/wasmer-call-native	1174.5±2.48ns	1157.5±1.43ns	-1.45%
decimal::pow/wasmi	286.1±0.45µs	283.1±0.68µs	-1.05%
decimal::pow/wasmi-call-native	7.5±0.01µs	7.5±0.01µs	0.00%
decimal::root/0	9.5±0.13µs	9.1±0.01µs	-4.21%
decimal::sub/0	9.4±0.01ns	9.4±0.01ns	0.00%
decimal::to_string/0	493.6±2.23ns	493.7±2.32ns	+0.02%
precise_decimal::add/0	11.3±0.46ns	10.4±0.24ns	-7.96%
precise_decimal::add/rust-native	12.6±0.09ns	12.7±0.00ns	+0.79%
precise_decimal::add/wasmer	131.4±0.10ns	135.6±0.35ns	+3.20%
precise_decimal::add/wasmer-call-native	571.4±1.54ns	576.2±0.85ns	+0.84%
precise_decimal::add/wasmi	1030.6±9.37ns	1089.0±7.16ns	+5.67%
precise_decimal::add/wasmi-call-native	9.1±0.01µs	8.8±0.01µs	-3.30%
precise_decimal::div/0	331.0±3.34ns	328.9±1.17ns	-0.63%
precise_decimal::from_string/0	219.3±0.47ns	219.3±0.41ns	0.00%
precise_decimal::mul/0	345.4±0.61ns	346.8±2.14ns	+0.41%
precise_decimal::mul/rust-native	338.7±1.93ns	325.1±0.47ns	-4.02%
precise_decimal::mul/wasmer	3.9±0.00µs	4.0±0.00µs	+2.56%
precise_decimal::mul/wasmer-call-native	978.2±5.80ns	922.4±0.68ns	-5.70%
precise_decimal::mul/wasmi	152.7±0.28µs	151.1±0.19µs	-1.05%
precise_decimal::mul/wasmi-call-native	9.6±0.02µs	9.2±0.01µs	-4.17%
precise_decimal::pow/0	1933.4±7.14ns	1960.5±8.30ns	+1.40%
precise_decimal::pow/rust-native	1603.0±11.31ns	1613.9±6.48ns	+0.68%
precise_decimal::pow/wasmer	18.2±0.01µs	18.1±0.01µs	-0.55%
precise_decimal::pow/wasmer-call-native	2.4±0.01µs	2.4±0.01µs	0.00%
precise_decimal::pow/wasmi	735.0±1.13µs	731.2±0.36µs	-0.52%
precise_decimal::pow/wasmi-call-native	16.8±0.02µs	16.8±0.06µs	0.00%
precise_decimal::root/0	65.9±0.04µs	62.8±0.06µs	-4.70%
precise_decimal::sub/0	10.6±0.02ns	10.6±0.02ns	0.00%
precise_decimal::to_string/0	772.6±0.72ns	776.5±0.64ns	+0.50%
schema::validate_payload	358.0±2.19µs	350.1±0.43µs	-2.21%
transaction::radiswap	6.4±0.06ms	6.5±0.93ms	+1.56%
transaction::transfer	2.0±0.00ms	2.0±0.01ms	0.00%
transaction_processing::prepare	3.0±0.01ms	3.0±0.04ms	0.00%
transaction_processing::prepare_and_decompile	7.1±0.02ms	7.0±0.01ms	-1.41%
transaction_processing::prepare_and_decompile_and_recompile	27.0±0.24ms	26.7±0.13ms	-1.11%
transaction_validation::validate_manifest	48.8±0.07µs	48.7±0.10µs	-0.20%
transaction_validation::verify_ecdsa	85.2±0.10µs	85.0±0.03µs	-0.23%
transaction_validation::verify_ed25519	60.8±0.06µs	60.3±0.14µs	-0.82%