Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --trace option to replay CLIs #1638

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

iamyulong
Copy link
Member

@iamyulong iamyulong commented Oct 30, 2023

Summary

  • Add --trace option to replay CLIs
  • Do not commit before state comparison

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Benchmark for 5febe4b

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 75.4±0.34ms 76.1±0.43ms +0.93%
costing::decode_sbor 16.7±0.05µs 16.3±0.05µs -2.40%
costing::decode_sbor_bytes 47.6±0.31µs 51.8±0.21µs +8.82%
costing::deserialize_wasm 1411.3±8.41µs 1399.7±6.93µs -0.82%
costing::instantiate_flash_loan 4.5±0.75ms 4.4±0.53ms -2.22%
costing::instantiate_radiswap 6.6±0.04ms 6.9±0.11ms +4.55%
costing::spin_loop 27.7±0.07ms 27.5±0.04ms -0.72%
costing::validate_sbor_payload 30.9±0.09µs 30.9±0.11µs 0.00%
costing::validate_sbor_payload_bytes 393.1±0.56ns 372.9±4.80ns -5.14%
costing::validate_secp256k1 87.5±0.04µs 87.5±0.04µs 0.00%
costing::validate_wasm 42.8±0.25ms 43.4±0.06ms +1.40%
decimal::add/0 9.3±0.04ns 9.3±0.00ns 0.00%
decimal::add/rust-native 10.8±0.01ns 10.9±0.01ns +0.93%
decimal::add/wasmer 136.6±0.66ns 136.0±0.40ns -0.44%
decimal::add/wasmer-call-native 589.9±1.04ns 567.8±1.68ns -3.75%
decimal::add/wasmi 836.7±2.75ns 834.3±5.56ns -0.29%
decimal::add/wasmi-call-native 8.2±0.01µs 8.2±0.02µs 0.00%
decimal::div/0 199.7±0.24ns 199.4±0.41ns -0.15%
decimal::from_string/0 167.1±0.38ns 165.1±0.43ns -1.20%
decimal::mul/0 155.3±0.16ns 158.6±0.19ns +2.12%
decimal::mul/rust-native 151.0±0.23ns 153.3±0.24ns +1.52%
decimal::mul/wasmer 1675.1±1.19ns 1687.1±7.24ns +0.72%
decimal::mul/wasmer-call-native 720.1±0.98ns 735.6±1.55ns +2.15%
decimal::mul/wasmi 60.5±0.13µs 60.6±0.27µs +0.17%
decimal::mul/wasmi-call-native 8.3±0.01µs 8.4±0.02µs +1.20%
decimal::pow/0 725.7±1.59ns 730.7±3.36ns +0.69%
decimal::pow/rust-native 700.1±0.66ns 698.3±0.86ns -0.26%
decimal::pow/wasmer 7.4±0.01µs 7.7±0.01µs +4.05%
decimal::pow/wasmer-call-native 1190.3±1.46ns 1172.7±2.29ns -1.48%
decimal::pow/wasmi 284.5±0.90µs 285.4±0.99µs +0.32%
decimal::pow/wasmi-call-native 7.4±0.01µs 7.4±0.04µs 0.00%
decimal::root/0 9.6±0.01µs 9.6±0.01µs 0.00%
decimal::sub/0 9.4±0.01ns 9.4±0.01ns 0.00%
decimal::to_string/0 478.0±0.36ns 480.9±0.44ns +0.61%
precise_decimal::add/0 10.5±0.04ns 10.4±0.02ns -0.95%
precise_decimal::add/rust-native 12.7±0.00ns 12.6±0.04ns -0.79%
precise_decimal::add/wasmer 139.2±0.57ns 140.1±0.77ns +0.65%
precise_decimal::add/wasmer-call-native 604.4±0.56ns 571.7±1.39ns -5.41%
precise_decimal::add/wasmi 1030.2±2.87ns 1031.1±5.58ns +0.09%
precise_decimal::add/wasmi-call-native 8.7±0.01µs 8.5±0.02µs -2.30%
precise_decimal::div/0 334.4±0.75ns 325.7±0.66ns -2.60%
precise_decimal::from_string/0 222.4±0.36ns 224.0±0.24ns +0.72%
precise_decimal::mul/0 357.3±0.53ns 346.1±0.21ns -3.13%
precise_decimal::mul/rust-native 324.4±0.31ns 321.4±3.12ns -0.92%
precise_decimal::mul/wasmer 3.8±0.00µs 4.1±0.03µs +7.89%
precise_decimal::mul/wasmer-call-native 939.7±0.86ns 925.4±8.01ns -1.52%
precise_decimal::mul/wasmi 152.0±0.42µs 152.2±0.69µs +0.13%
precise_decimal::mul/wasmi-call-native 9.1±0.01µs 9.1±0.01µs 0.00%
precise_decimal::pow/0 1937.3±5.17ns 1947.0±7.31ns +0.50%
precise_decimal::pow/rust-native 1612.0±6.92ns 1628.3±2.23ns +1.01%
precise_decimal::pow/wasmer 18.1±0.01µs 18.8±0.01µs +3.87%
precise_decimal::pow/wasmer-call-native 2.3±0.00µs 2.3±0.00µs 0.00%
precise_decimal::pow/wasmi 733.3±1.74µs 737.2±2.05µs +0.53%
precise_decimal::pow/wasmi-call-native 16.8±0.02µs 16.8±0.02µs 0.00%
precise_decimal::root/0 65.1±0.03µs 64.6±0.02µs -0.77%
precise_decimal::sub/0 10.6±0.02ns 10.5±0.00ns -0.94%
precise_decimal::to_string/0 777.4±1.34ns 779.6±1.20ns +0.28%
schema::validate_payload 351.2±1.46µs 346.0±0.49µs -1.48%
transaction::radiswap 6.4±0.04ms 6.4±0.07ms 0.00%
transaction::transfer 2.0±0.00ms 2.0±0.00ms 0.00%
transaction_processing::prepare 3.0±0.00ms 2.9±0.00ms -3.33%
transaction_processing::prepare_and_decompile 7.1±0.01ms 7.3±0.02ms +2.82%
transaction_processing::prepare_and_decompile_and_recompile 26.6±0.11ms 27.0±0.11ms +1.50%
transaction_validation::validate_manifest 48.7±0.23µs 48.7±0.10µs 0.00%
transaction_validation::verify_ecdsa 85.1±0.09µs 85.2±0.36µs +0.12%
transaction_validation::verify_ed25519 61.0±0.09µs 60.9±0.05µs -0.16%

@iamyulong iamyulong merged commit 87c73dd into develop Oct 31, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants