-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] replay command: heap memory alloc dump #1637
Conversation
Benchmark for 4f71fceClick to view benchmark
|
val.sum_counter.store(0, Ordering::Release); | ||
val.current_level.store(0, Ordering::Release); | ||
val.max_level.store(0, Ordering::Release); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need atomics if they're thread-local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a leftover from a previous implementation (when counter was shared between threads), should be fine to change to ordinary number type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed counter types, but it requires usage of ReffCell
as thread local data due to needed interior mutability (atomics are implemented using UnsafeCell
internally).
Summary
Added command to execute transactions from archive and dump memory allocated during execution.
Refactored
InfoAlloc
module to support multi-threading and moved toradix-engine-profiling
project.