Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde::Serialize/Deserialize to AttachedModuleId #1632

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

talekhinezh
Copy link
Member

Summary

Add Serialize/Deserialize to AttachedModuleId for the purpose fuzzing

@talekhinezh talekhinezh marked this pull request as ready for review October 19, 2023 15:38
@github-actions
Copy link

Benchmark for fcfa998

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 76.0±0.45ms 76.0±0.32ms 0.00%
costing::decode_sbor 16.9±0.03µs 16.8±0.10µs -0.59%
costing::decode_sbor_bytes 46.7±0.05µs 48.1±0.41µs +3.00%
costing::deserialize_wasm 1393.3±3.76µs 1400.7±10.53µs +0.53%
costing::instantiate_flash_loan 4.2±0.58ms 4.2±0.61ms 0.00%
costing::instantiate_radiswap 5.7±0.04ms 5.7±0.04ms 0.00%
costing::spin_loop 27.7±0.07ms 27.6±0.11ms -0.36%
costing::validate_sbor_payload 30.5±0.07µs 33.3±0.10µs +9.18%
costing::validate_sbor_payload_bytes 372.5±0.74ns 377.8±0.83ns +1.42%
costing::validate_secp256k1 87.6±0.05µs 87.5±0.05µs -0.11%
costing::validate_wasm 43.6±0.09ms 43.6±0.10ms 0.00%
decimal::add/0 9.3±0.00ns 9.3±0.00ns 0.00%
decimal::add/rust-native 10.8±0.00ns 10.9±0.03ns +0.93%
decimal::add/wasmer 134.9±0.44ns 127.6±0.27ns -5.41%
decimal::add/wasmer-call-native 559.1±1.15ns 552.0±0.57ns -1.27%
decimal::add/wasmi 904.8±3.68ns 859.1±4.17ns -5.05%
decimal::add/wasmi-call-native 10.5±0.01µs 8.4±0.00µs -20.00%
decimal::div/0 197.8±0.44ns 199.2±0.21ns +0.71%
decimal::from_string/0 168.8±0.61ns 168.2±0.38ns -0.36%
decimal::mul/0 157.2±0.24ns 157.6±0.13ns +0.25%
decimal::mul/rust-native 152.1±0.53ns 149.8±0.12ns -1.51%
decimal::mul/wasmer 1690.3±0.74ns 1687.4±0.89ns -0.17%
decimal::mul/wasmer-call-native 704.1±0.55ns 700.9±0.59ns -0.45%
decimal::mul/wasmi 63.9±0.09µs 60.2±0.05µs -5.79%
decimal::mul/wasmi-call-native 10.7±0.01µs 8.4±0.01µs -21.50%
decimal::pow/0 731.2±2.97ns 721.1±0.86ns -1.38%
decimal::pow/rust-native 696.5±1.69ns 701.1±1.66ns +0.66%
decimal::pow/wasmer 7.3±0.01µs 7.3±0.00µs 0.00%
decimal::pow/wasmer-call-native 1168.7±0.94ns 1165.1±1.34ns -0.31%
decimal::pow/wasmi 299.0±0.26µs 279.6±0.48µs -6.49%
decimal::pow/wasmi-call-native 9.0±0.01µs 7.4±0.01µs -17.78%
decimal::root/0 9.4±0.01µs 9.2±0.01µs -2.13%
decimal::sub/0 9.4±0.01ns 9.4±0.01ns 0.00%
decimal::to_string/0 493.2±5.48ns 486.8±2.58ns -1.30%
precise_decimal::add/0 10.3±0.13ns 10.3±0.11ns 0.00%
precise_decimal::add/rust-native 12.6±0.02ns 12.7±0.00ns +0.79%
precise_decimal::add/wasmer 135.1±0.82ns 134.4±0.26ns -0.52%
precise_decimal::add/wasmer-call-native 572.8±0.87ns 573.7±0.85ns +0.16%
precise_decimal::add/wasmi 1120.7±3.85ns 1112.8±5.94ns -0.70%
precise_decimal::add/wasmi-call-native 11.1±0.02µs 8.8±0.03µs -20.72%
precise_decimal::div/0 324.5±0.49ns 328.2±0.98ns +1.14%
precise_decimal::from_string/0 226.5±0.54ns 226.4±0.18ns -0.04%
precise_decimal::mul/0 352.0±2.58ns 354.9±2.95ns +0.82%
precise_decimal::mul/rust-native 340.2±7.50ns 335.6±2.17ns -1.35%
precise_decimal::mul/wasmer 3.9±0.00µs 4.2±0.00µs +7.69%
precise_decimal::mul/wasmer-call-native 936.2±1.52ns 934.6±1.20ns -0.17%
precise_decimal::mul/wasmi 160.0±0.19µs 150.8±0.17µs -5.75%
precise_decimal::mul/wasmi-call-native 11.5±0.01µs 9.4±0.01µs -18.26%
precise_decimal::pow/0 2.0±0.01µs 2.0±0.01µs 0.00%
precise_decimal::pow/rust-native 1604.6±7.57ns 1568.9±3.99ns -2.22%
precise_decimal::pow/wasmer 18.0±0.01µs 18.0±0.01µs 0.00%
precise_decimal::pow/wasmer-call-native 2.4±0.00µs 2.3±0.01µs -4.17%
precise_decimal::pow/wasmi 771.1±0.26µs 727.0±0.83µs -5.72%
precise_decimal::pow/wasmi-call-native 19.1±0.06µs 16.5±0.02µs -13.61%
precise_decimal::root/0 64.7±0.08µs 64.4±0.04µs -0.46%
precise_decimal::sub/0 10.5±0.01ns 10.5±0.00ns 0.00%
precise_decimal::to_string/0 770.3±1.82ns 785.4±23.44ns +1.96%
schema::validate_payload 357.1±0.98µs 359.8±1.03µs +0.76%
transaction::radiswap 6.5±0.21ms 6.5±0.07ms 0.00%
transaction::transfer 2.1±0.01ms 2.1±0.00ms 0.00%
transaction_processing::prepare 2.9±0.01ms 2.9±0.00ms 0.00%
transaction_processing::prepare_and_decompile 7.3±0.01ms 7.2±0.02ms -1.37%
transaction_processing::prepare_and_decompile_and_recompile 27.2±0.14ms 26.4±0.11ms -2.94%
transaction_validation::validate_manifest 48.9±0.54µs 48.8±0.04µs -0.20%
transaction_validation::verify_ecdsa 85.0±0.07µs 85.0±0.13µs 0.00%
transaction_validation::verify_ed25519 60.9±0.10µs 60.9±0.05µs 0.00%

@talekhinezh talekhinezh merged commit 95da402 into develop Oct 19, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants