[ABW-3932] Factor Source detail view #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
reviewed
Jan 6, 2025
| .header(L10n.FactorSources.Detail.test), | ||
| spotCheckRow(viewStore), | ||
| .header(L10n.FactorSources.Detail.advanced), | ||
| // TODO: Define how to handle case where seed phrase was never entered |
There was a problem hiding this comment.
added support for this
GhenadieVP
approved these changes
Jan 7, 2025
|
@matiasbzurovski I see that details view does not match the zeplin screens. |
|
@giannis-rdx video is outdated from when I created PR (which had older designs), will update |
no need then! I just thought we had new screens that i was not aware of |
matiasbzurovski
force-pushed
the
ABW-3932-factor-source-detail
branch
from
969e472 to
8f5784e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3932
Description
This PR shows the detail view for every supported Factor Source kind.
Also, merges
UpdateAccountLabel&UpdateP2PLinkNameinto one singleRenameLabelfeature that also supports renaming aFactorSource.Notes
For now, it will only allow to rename the Factor Source, as well as view its seed phrase for the
devicecase. The spot check will be implemented later (after integratingKeysCollector).Also, for
devicedetails, if you try to view the seed phrase when it hasn't been entered, an error alert is shown (check video for reference). We may wanna update the flow to allow user to enter the seed phrase directly when reaching this state.Video
Link