Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource holders endpoint. #755

Merged
merged 18 commits into from
Aug 16, 2024
Merged

Resource holders endpoint. #755

merged 18 commits into from
Aug 16, 2024

Conversation

PawelPawelec-RDX
Copy link
Contributor

No description provided.

dhedey
dhedey reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from 2d326eb to b8f1f86 Compare August 8, 2024 10:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-database-migrations:HEAD-ec2e6e7-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-gateway-api:HEAD-ec2e6e7-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-data-aggregator:HEAD-ec2e6e7-arm64

@PawelPawelec-RDX PawelPawelec-RDX changed the base branch from main to develop August 8, 2024 10:54
krzlabrdx
krzlabrdx suggested changes Aug 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/Services/IExtensionsQuerier.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/CommonDbContext.cs Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/CommonDbContext.cs Show resolved Hide resolved
...RadixDlt.NetworkGateway.PostgresIntegration/LedgerExtension/PostgresLedgerExtenderService.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/LedgerExtension/WriteHelper.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Services/ExtensionsQuerier.cs Show resolved Hide resolved
@PawelPawelec-RDX PawelPawelec-RDX changed the title [WIP] api proposition for resource owners endpoint. resource owners endpoint. Aug 13, 2024
@PawelPawelec-RDX PawelPawelec-RDX marked this pull request as ready for review August 13, 2024 08:52
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from 86fb9ba to 7d5a180 Compare August 13, 2024 09:01
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from d071f8d to 9ef2acf Compare August 14, 2024 09:18
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from 9ef2acf to 5bb2889 Compare August 14, 2024 14:37
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from 8c0dfa0 to ec6222c Compare August 15, 2024 08:30
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-owners-api-schema branch from ec6222c to be97fd4 Compare August 15, 2024 08:31
dhedey
dhedey requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

A couple of key comments - a slightly annoying reflection on naming; and a question around page size.

src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/gateway-api-schema.yaml Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.GatewayApi/Handlers/DefaultExtensionsHandler.cs Outdated Show resolved Hide resolved
@dhedey dhedey changed the title resource owners endpoint. Resource holders endpoint. Aug 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
26 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PawelPawelec-RDX PawelPawelec-RDX merged commit b4917af into develop Aug 16, 2024
2 of 10 checks passed
@PawelPawelec-RDX PawelPawelec-RDX deleted the resource-owners-api-schema branch August 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhedey dhedey dhedey approved these changes

@krzlabrdx krzlabrdx krzlabrdx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PawelPawelec-RDX @dhedey @krzlabrdx