Merge pull request #533 from radixdlt/fix-page-size-validation

use same MaxPageSize as default page limit (100). Add validation that…
radixdlt · Oct 11, 2023 · ae895c0 · ae895c0
2 parents 59075d7 + 8e6f7de
commit ae895c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.0.2 - Babylon
+Release Date: _unreleased_
+
+- Changed default configuration value of MaxPageSize for endpoints to 100. Validate if max page size is higher than DefaultPageSize.
+
 ## 1.0.1 - Babylon 
 Release Date: _unreleased_
 

diff --git a/apps/GatewayApi/appsettings.json b/apps/GatewayApi/appsettings.json
@@ -25,9 +25,6 @@
     "EnableSwagger": true,
 
     "GatewayApi": {
-        "Endpoint": {
-            "MaxPageSize": 30,
-        },
         "AcceptableLedgerLag": {
             "PreventReadRequestsIfDbLedgerIsBehind": true,
             "ReadRequestAcceptableDbLedgerLagSeconds": 60,

diff --git a/src/RadixDlt.NetworkGateway.GatewayApi/Configuration/EndpointOptions.cs b/src/RadixDlt.NetworkGateway.GatewayApi/Configuration/EndpointOptions.cs
@@ -104,6 +104,9 @@ internal class EndpointOptionsValidator : AbstractOptionsValidator<EndpointOptio
     public EndpointOptionsValidator()
     {
         RuleFor(x => x.MaxPageSize).GreaterThan(0);
+        RuleFor(x => x.MaxPageSize)
+            .GreaterThanOrEqualTo(x => x.DefaultPageSize)
+            .WithMessage("{PropertyName} has to be bigger than {ComparisonProperty}. {PropertyName}:{PropertyValue}, {ComparisonProperty}:{ComparisonValue}");
         RuleFor(x => x.DefaultNonFungibleIdsPageSize).GreaterThan(0);
         RuleFor(x => x.DefaultTransactionsStreamPageSize).GreaterThan(0);
         RuleFor(x => x.RequestTimeout).GreaterThan(TimeSpan.Zero);