Skip to content

Commit

Permalink
CRAN 1.6.2
Browse files Browse the repository at this point in the history
  • Loading branch information
vnijs committed Oct 16, 2023
1 parent 8796b6e commit f3208de
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: radiant.data
Title: Data Menu for Radiant: Business Analytics using R and Shiny
Version: 1.6.2
Date: 2023-10-12
Date: 2023-10-15
Authors@R: c(
person("Vincent", "Nijs", email = "[email protected]", role = c("aut", "cre")),
person("Niklas", "von Hertzen", email = "[email protected]", role = c("aut"), comment = "html2canvas library")
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# radiant.data 1.6.2

* Changed knitr option so that usernames with a space are allowed on windows
* Fixed a bug in Radiant by changing knitr options. Usernames with a space should no longer cause issues on Windows

# radiant.data 1.6.0

Expand Down
16 changes: 15 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
## Resubmission

This is a resubmission. In this version I have fixed a bug that caused problems for users on Windows with a space in their username. See NEWS.md for details.

## Test environments

* macOS, R 4.3.1
* win-builder (devel)

## R CMD check results

There were no ERRORs or WARNINGs. There was one NOTE related to the number of non-standard dependencies. However, this note is not easily addressed without substantially inconveniencing users that rely on the web (shiny) interface available for radiant.data.

# Previous cran-comments

## Resubmission

This is a resubmission. In this update I fixed a strange issue related the patchwork package. At least it was strange to me. In the code below `any` should not be needed. However, it seems that a patchwork object can have length == 1 and still have is.na return a vector of length > 1. Perhaps there are other libraries that have objects like this but I have never seen this before.

My apologies for submitting a new version so soon after the previous version.
Expand All @@ -17,7 +32,6 @@ length(x) == 0 || (length(x) == 1 && any(is.na(x)))

There were no ERRORs or WARNINGs. There was one NOTE related to the number of non-standard dependencies. However, this note is not easily addressed without substantially inconveniencing users that rely on the web (shiny) interface available for radiant.data.

# Previous cran-comments

## Resubmission

Expand Down

0 comments on commit f3208de

Please sign in to comment.