Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve formatter executable commands prior to calling them #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tylerjl
Copy link

@tylerjl tylerjl commented Jan 18, 2025

Hi! Thanks for your work on apheleia, it's great.

An issue I've run into recently is that sometimes my remote executables aren't immediately in-$PATH: I need to resolve them via executable-find - which does find them - before invoking the process. This should be safe, given that the step is performed at a prior step. I'm overwriting the command variable since I infer that the executable name is being reused later when you're matching a callback, I think?

I mentioned that executable-find happens earlier in the call chain so I could maybe improve this by removing that and only resolving the executable once, but I wanted to check in with you to determine whether the overall problem and solution even make sense to somebody else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant