Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #697

Closed
wants to merge 6 commits into from
Closed

Automated Resyntax fixes #697

wants to merge 6 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Nov 18, 2024

This is an automated change generated by Resyntax.

Pass 1

Applied 13 fixes to drracket/drracket/private/language.rkt

  • Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 289, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 352, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 609, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 715, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 749, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 911, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 935, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 974, cond-let-to-cond-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 982, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 1055, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 1068, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 1274, make-temporary-directory-migration: Use make-temporary-directory to make directories instead of make-temporary-file.

Applied 2 fixes to drracket/setup/plt-installer-unit.rkt

  • Line 2, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 44, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.

Applied 1 fix to drracket/help/private/bug-report-controls.rkt

  • Line 143, unused-definition: This definition is not used.

Applied 1 fix to drracket/scribble/tools/drracket-buttons.rkt

  • Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Pass 2

Applied 1 fix to drracket/drracket/private/language.rkt

  • Line 1091, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.

Summary

Fixed 18 issues in 4 files.

  • Fixed 12 occurrences of let-to-define
  • Fixed 3 occurrences of tidy-require
  • Fixed 1 occurrence of make-temporary-directory-migration
  • Fixed 1 occurrence of cond-let-to-cond-define
  • Fixed 1 occurrence of unused-definition

Keep imports in `require` sorted and grouped by phase, with collections before files.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
This definition is not used.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
@@ -140,37 +140,8 @@
(inner (void) after-delete a b))
(super-new)))

(define (make-big-text label #:key [key #f] #:stretch? [stretch? #f] #:top-panel [top-panel top-panel] #:vertical? [vertical? #f])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletion broke the code, since this function is still used. Not sure what happened here. I've opened jackfirth/resyntax#410 for this.

@jackfirth jackfirth closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant