-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Resyntax fixes #683
Conversation
This is an automated change generated by Resyntax. #### Pass 1 Applied 1 fix to [`drracket/drracket/private/syncheck/blueboxes-gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/blueboxes-gui.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 12 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 385, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 403, `define-lambda-to-define`: The `define` form supports a shorthand for defining functions (including function-returning functions). * Line 2141, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2192, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2356, `inline-unnecessary-define`: This variable is returned immediately and can be inlined. * Line 2464, `define-lambda-to-define`: The `define` form supports a shorthand for defining functions (including function-returning functions). * Line 2612, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2640, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2650, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2726, `cond-let-to-cond-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2755, `flat-contract-migration`: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now. Applied 1 fix to [`drracket/drracket/private/syncheck/intf.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/intf.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 2 Applied 6 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 387, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 403, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2090, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2588, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2598, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. ## Summary Fixed 20 issues in 3 files. * Fixed 11 occurrences of `let-to-define` * Fixed 4 occurrences of `tidy-require` * Fixed 2 occurrences of `define-lambda-to-define` * Fixed 1 occurrence of `inline-unnecessary-define` * Fixed 1 occurrence of `cond-let-to-cond-define` * Fixed 1 occurrence of `flat-contract-migration`
This diff is way too big. Filed jackfirth/resyntax#321 to add a limit for that. |
(class* | ||
(docs-text-defs-mixin super%) | ||
(syncheck-text<%>) | ||
(inherit set-cursor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in class*, I'd like the keep the super class and the super interfaces on the first line and then have a newline. Is that possible @sorawee ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally! See sorawee/fmt#73
I can't tell what's going on in the big diff. I'm not sure if this is a problem with the diff visualization algorithm on github or what. |
Yeah this one's unreadable. I'm gonna close it and go implement a line limit. |
This is an automated change generated by Resyntax.
Pass 1
Applied 1 fix to
drracket/drracket/private/syncheck/blueboxes-gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.Applied 12 fixes to
drracket/drracket/private/syncheck/gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.define-lambda-to-define
: Thedefine
form supports a shorthand for defining functions (including function-returning functions).let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.inline-unnecessary-define
: This variable is returned immediately and can be inlined.define-lambda-to-define
: Thedefine
form supports a shorthand for defining functions (including function-returning functions).let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.cond-let-to-cond-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.flat-contract-migration
: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.Applied 1 fix to
drracket/drracket/private/syncheck/intf.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.Pass 2
Applied 6 fixes to
drracket/drracket/private/syncheck/gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.Summary
Fixed 20 issues in 3 files.
let-to-define
tidy-require
define-lambda-to-define
inline-unnecessary-define
cond-let-to-cond-define
flat-contract-migration