Automated Resyntax fixes #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 1 fix to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 4 fixes to [`drracket/drracket/drracket.rkt`](../blob/HEAD/drracket/drracket/drracket.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 26, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 93, `map-to-for`: This `map` operation can be replaced with a `for/list` loop. * Line 143, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. Applied 2 fixes to [`drracket-tool-text-lib/drracket/private/syncheck/annotate.rkt`](../blob/HEAD/drracket-tool-text-lib/drracket/private/syncheck/annotate.rkt) * Line 13, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 57, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. Applied 2 fixes to [`drracket/drracket/private/tooltip.rkt`](../blob/HEAD/drracket/drracket/private/tooltip.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 119, `delete-redundant-let`: This `let` binding does nothing and can be removed. Applied 1 fix to [`drracket/drracket/private/tracing.rkt`](../blob/HEAD/drracket/drracket/private/tracing.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. ## Summary Fixed 10 issues in 5 files. * Fixed 4 occurrences of `tidy-require` * Fixed 4 occurrences of `let-to-define` * Fixed 1 occurrence of `map-to-for` * Fixed 1 occurrence of `delete-redundant-let`
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 5 files in this pull request and has added suggestions.
|
I should probably should set up the resyntax reviewer bot to not bother reviewing pull requests from the autofixer bot... |
jackfirth
reviewed
Sep 20, 2024
Comment on lines
+30
to
+37
| (void (thread (λ () | ||
| (let loop () | ||
| (define vec (sync evt)) | ||
| (define str (vector-ref vec 1)) | ||
| (when (regexp-match #rx"^cm: *compil(ing|ed)" str) | ||
| (display str) | ||
| (newline)) | ||
| (loop)))))) |
There was a problem hiding this comment.
Not a fan of this indentation change, filed sorawee/fmt#72
|
I'm closing this one since it's from before the autofixer got better at focusing on fully fixing the files it touches with multiple passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 1 fix to
drracket/drracket/private/syncheck/gui.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 4 fixes to
drracket/drracket/drracket.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.map-to-for: Thismapoperation can be replaced with afor/listloop.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Applied 2 fixes to
drracket-tool-text-lib/drracket/private/syncheck/annotate.rktlet-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Applied 2 fixes to
drracket/drracket/private/tooltip.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.delete-redundant-let: Thisletbinding does nothing and can be removed.Applied 1 fix to
drracket/drracket/private/tracing.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Summary
Fixed 10 issues in 5 files.
tidy-requirelet-to-definemap-to-fordelete-redundant-let