Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the cc2olx converter usage with correct Common Cartridge course
.imscc
dumps some problems with CC XML processing were encountered. It caused by handling of special cases by the converter while the actual CC XML can be much more complicated. This PR is intended to solve the encountered problems.Also, it's found out that cc2olx completely ignores the fact that both OeX "Text Problem" and CC "Fill in the blank" support regexps, so their support is added.
Steps to reproduce
Untitled quiz item
.imscc
dump (or use the attached oneuntitled_quiz_item_dump.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withitem
that doesn't havetitle
attribute.For example,
KeyError
message.Section with not
root_section
identifier.imscc
dump (or use the attached onesection_with_not_root_section_identifier.imscc.zip but remove
.zip
extention leaving.imscc
): ensure you have theassessment
withsection
whichident
attribute value isn'troot_section
.For example,
respcondition
withoutcontinue
attribute.imscc
dump (or use the attached one respcondition_without_continue_attribute.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withrespcondition
withoutcontinue
attribute.For example,
KeyError
message.material
is not direct child ofsolutionmaterial
.imscc
dump (or use the attached one material_is_not_direct_child_of_solutionmaterial.zip but remove.zip
extention leaving.imscc
): ensure you have theassessment
withitemfeedback
,itemfeedback
hassolution
child,solution
hassolutionmaterial
,material
is not a direct child ofsolutionmaterial
:flow_mat
is asolutionmaterial
child,material
is aflow_mat
child.For example,
AttributeError
message.Fill in the blank
with regexp.imscc
dump (or use the attached one fib_with_regexp.imscc.zip but remove.zip
extention leaving.imscc
): ensure you have theFill in the blank
assessment withresprocessing
that containsrespcondition
withvarsubstring
inconditionvar
.For example,
IndexError
message.Deadline
"None"