Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs in OptExtract; good progress in making repository Python 3 compatible #20

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ideasrule
Copy link

OptExtract:

  • Marsh.c now fully Python 3 compatible
  • Fixed bug where Marsh_SObtainSpectrum pointed to same function as Marsh_ObtainSpectrum, and similarly with Marsh_SObtainP. Removed Marsh_SSimpleExtract, since it's not implemented.
  • Fixed several mistakes in the documentation and comments
  • Fixed several compiler warnings by removing dead code
  • Better installation instructions

Python files:

  • Ran reindent.py (part of Python) so that all files use spaces, not a mixture of spaces and tabs (which is disallowed in Python 3)
  • Ran 2to3 to make all print statements compatible with Python 3
  • StringIO import now works for Python 3

Other:

  • C files in Continuum are now Python 3 compatible

These changes don't make the repository fully Python 3 compatible--the SSEphem Makefile still needs to be manually changed, for example. Also, I haven't tested these changes much, so beware hidden problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant