khepri_cluster: Stop spamming cluster with join/leave if it is not ready #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why]
If a cluster change (a member joining or leaving), it is not permitted
to make another change: Ra will reply with the following error:
{error, cluster_change_not_permitted}
Before this patch, we would retry immediately after such an error. We
were effeclively spamming the Ra server with many join/leave commands,
but the user too with hundreds of "not ready; waiting..." log messages.
[How]
For now, we simply add a hard-coded 200 ms sleep before retrying.
the-mikedavis
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 89.59% 89.64% +0.04%
==========================================
Files 21 21
Lines 3192 3195 +3
==========================================
+ Hits 2860 2864 +4
+ Misses 332 331 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
deleted the
stop-spamming-with-cluster-change-commands-if-cluster-not-ready
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If a cluster change (a member joining or leaving), it is not permitted to make another change: Ra will reply with the following error:
{error, cluster_change_not_permitted}Before this patch, we would retry immediately after such an error. We were effeclively spamming the Ra server with many join/leave commands, but the user too with hundreds of "not ready; waiting..." log messages.
How
For now, we simply add a hard-coded 200 ms sleep before retrying.