Spar viewer: Fixes and New Features #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The warning is related to a potential performance issue with Qt containers when used in C++11 range-based for loops "c++11 range-loop might detach Qt container (QList) [clazy-range-loop-detach]" 2) tmp variable unused in exit() function
This was showing clipped data from the display
A toogle button was added to lock the axes. Sometimes it's annoying to have the axes changing the settings constantly when managing traces
This is settings allows the changes on the graph to be more dynamic
Fixed save() function Load session feature Load settings file with drag and drop Load session feature
5 points per div. It's smooth enough
Trying to solve CI errors
|
Will smith chart and polar plotting be added? |
|
I would like the tool to be able to plot data on a Smith chart, at least. I'll try to add that as soon as I can. First I need to find an open source library with a Smith Chart widget, Qt doesn't include that. Otherwise, I'll need to write it from scratch and that'll take more time. |
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
I've been using the tool and found some issues. While I was at it, I added some features:
Fixed issues
New Features
Lock button: A button has been added to freeze the axis settings. This is necessary because the tool automatically adjusts the axes when the user adds a new trace. This behavior is correct and makes the tool more dynamic, but it can be annoying when the user is focused on a specific band and wants to add and remove traces.
Limit line: Most network analyzers I have worked with have this feature. This is used to check if your measurement meets the gain mask, RL, etc.
Save / Open Session: This feature saves the current state of the tool to an XML file. This saves time as the user does not have to enter the limits and marker stuff every time he/she uses the tool.
Here is a screencast:
https://drive.google.com/file/d/1ZdGebMBIh8tHjbdxuHGOIi8Ydwcz4yNz/view?usp=sharing