Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching tool: Keep dialog open in case the synthesis goes wrong #909

Conversation

andresmmera
Copy link
Contributor

As pointed out in issue #905, the dialog closes if the synthesis goes wrong. This can be annoying since the user needs to input all the design data again. Keeping the dialog open allows the user to make corrections.

A condition has been added at the end of the slotButtCreate() function to keep the dialog open in case the synthesis goes wrong. If the synthesis is ok, the program will exit as usual.

A condition has been added to slotButtCreate() to keep the dialogue open in case the synthesis goes wrong. This allows the user to fix the input parameters as requested in issue ra3xdh#905.
@ra3xdh ra3xdh linked an issue Aug 24, 2024 that may be closed by this pull request
@ra3xdh ra3xdh added this to the 24.4.0 milestone Aug 24, 2024
@ra3xdh ra3xdh merged commit aa688a6 into ra3xdh:current Aug 24, 2024
7 checks passed
@ra3xdh
Copy link
Owner

ra3xdh commented Aug 24, 2024

Thanks! Merged.

@andresmmera andresmmera deleted the Matching_Tool_Keep_Dialog_Open_if_wrong_input branch August 24, 2024 16:43
@ra3xdh ra3xdh modified the milestones: 24.4.0, 24.3.1 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matching Circuit Tool generates wrong results
2 participants