S-parameter Viewer: Some improvements #1133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple code editor example provided by Qt [1] was included in the tool. It is very convenient to have a text pad to include comments on the traces displayed. The notes are saved into the session file and they are restored when a session file is opened. [1] https://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html
It was found useful to have a "Recent Files" list with the last 10 sessions, this allows the user to quickly load a session file he/she worked recently.
It was found that when a session file is loaded the width of the traces was 1 regardless the trace setting. The pen width was omitted... This commit fixes this problem.
Before this commit, all traces associated to a S-parameter file were saved in the session file even if the user was not displaying them. This causes a heavy overhead specially in large files. Now, the session file only contains S-parameter data. If the user wants to display additional traces such as K, mu, |delta|, etc., they are computed on demand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following improvements and fixes to the S-parameter viewer tool:
Note-taking feature: When comparing S-parameter traces, I've found it useful to add a notepad widget so I can add my observations. The comments are saved in the .spar file and so they can check them later. Notice that I didn't write this tool, I've just simply took the note-taking Qt example [1]
Recent files feature
Bug fix: When loading the .spar session file, the width of the traces was 1 regardless of the previous trace setting.
Data management improvement: Now the tool saves only S-par data into the .spar files. Before this, all possible traces were saved into the .spar file, even if the user did not display them. This caused a lot of overhead, especially for large s-par data files. Now the tool only saves the raw S-parameter data.
[1] https://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html