Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path. #1124

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix path. #1124

merged 2 commits into from
Dec 10, 2024

Conversation

dsm
Copy link
Collaborator

@dsm dsm commented Dec 5, 2024

Hi, I just fixed some path, AppImage first run can't find ngspice. Adding double seperator cause issue. Sometimes windows don't find but I can't find to way to delete settings (first run case)

@ra3xdh ra3xdh added this to the 25.1.0 milestone Dec 6, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Dec 6, 2024

What happens when QucsSettings.BinDir has no separator on the end? Maybe to put the QDir::separator() between the BinDir and ngspice.exe?

@dsm
Copy link
Collaborator Author

dsm commented Dec 6, 2024

I think, I use something like that. QDir(QucsSettings.BinDir).absoluteFilePath("ngspice.exe")

example:

QString BinDir =     QucsDir.canonicalPath();
qDebug() << "Application Directory:" <<BinDir<<'\n'<< QDir(BinDir).absoluteFilePath("ngspice.exe");

output:

Application Directory: "C:/Users/MuhammetDemir/Documents/untitled/build/bin" 
 "C:/Users/MuhammetDemir/Documents/untitled/build/bin/ngspice.exe"

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 6, 2024

I think, I use something like that.

Yes, this will be also a solution.

@dsm
Copy link
Collaborator Author

dsm commented Dec 6, 2024

I try to change thanks.

@dsm dsm marked this pull request as draft December 6, 2024 19:47
@dsm dsm marked this pull request as ready for review December 7, 2024 10:22
@dsm dsm marked this pull request as draft December 7, 2024 16:29
@dsm dsm marked this pull request as ready for review December 7, 2024 18:38
@dsm
Copy link
Collaborator Author

dsm commented Dec 9, 2024

@ra3xdh I'm done with this PR.

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 10, 2024

Yes, the QStandardPaths is a better solution. Merging. Don't forget to test everything in a fresh VM before the release.

@ra3xdh ra3xdh merged commit 0fe4bc4 into ra3xdh:current Dec 10, 2024
8 checks passed
@dsm
Copy link
Collaborator Author

dsm commented Dec 10, 2024

Yes, I delete settings file and test all AppImage, Windows, and MacOS release but In MacOS it's hard to delete settings because OS is extreme caching and deleting not worked. I completely delete and reboot OS then everything is normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants