-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI improvements #1091
CI improvements #1091
Conversation
@dsm
|
|
|
The Qt5 support will be removed in the next year. See #983. I would advise don't touch Qt5 related stuff, because it is a candidate for removing.
The MSVC target must present only for research purposes. The CI should only give a warning but not error if this compiler fails. I am not sure if this is possible. Many of Qucs-S contributors don't own the license for MS development tools. I also have no wish to purchase license. I remember that MSVC had some difference in C++ standards support in the past. The Qt also had some MSVC specific problems. The blocking error from CI MSVC target may potentially create difficulties in accepting contribution. And the Windows release package should be built only with free compilers (MSYS2+MinGW environment)
This may be accepted. It doesn't interfere other compilers. |
@ra3xdh Visual Studio has community edition so we can use on public project with no problem(we don't need any license). I'll try to solve any problem with MSVC, yes default MSVC compiler isn't match C++ standarts but it has many flags to match C++ standarts. I want MSVC because of Windows on ARM it is easy to cross compile on x64 machine. I move qt5 to deploy.yml because of management sometimes Qt5 build failed but we don't realize it. We can easily removed in deploy.yml when we need. |
we have a macos brew in this link [email protected]. I have to change just version number if it's increase but we have a commit hash in file name I have to change this file for every new commits. So this problem we put hash to application tile to identify which version. I can add hash to others but not macos. |
I added a commit for this. |
Yes, this is acceptable. |
@ra3xdh Should I add short hash to filenames (except macos because of homebrew) |
@dsm Yes, adding hash to continuous build packages may be useful to distinguish different builds. |
is there something wrong with msys2 builds? |
No, it is just an alternative build. I am experimenting. |
@Kreijstal The release build must remain on the free development tools (MSYS2+MinGW). We have no plans to switch it to the MSVC. The MSVC build is only for experiments with another compilers. It is marked as |
@ra3xdh I need to test this changes one or two more cases. |
@ra3xdh Hi, I finish my test. |
Merged. The MSVC build should be available now. |
Hi @ra3xdh, this PR;