S-parameter Viewer: More fixes #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite weird to have this button checkable. It gives the feeling that the GUI is frozen.
Before loading a session file it is needed to clear the current dataset and traces.
It was found that before this commit the program had problems to load session files. Specifically, it didn't catch the axes limit and it also had problems if the previous session was saved with the lock status = true
It was found that when a limit was removed, the separator related to it stayed there. This commit fixes this.
It was found that after a trace/limit/marker is removed, if the user adds a new trace/limit/marker, the new widgets overlap the last ones. This happened because the position of the widgets in the QGridLayoyt were not updated after a trace/limit/marker is removed. This commit addresses this issue.
It was added an offset feature to move all the limits on a row.
|
@ra3xdh Please wait until tomorrow evening to merge this. I would like to try the Windows artifact. |
Now when the user adds a marker, the program adds a little text at the top of the marker line indicating the frequency.
andresmmera
force-pushed
the
SPAR_Viewer_Fixes
branch
from
29a343f to
1ce2092
Compare
|
Is this PR ready for merge now? |
|
Yes, it's ready. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more extensive testing, the following issues were spotted:
All these problems have been fixed in this PR.
In addition, a global offset limit has been added. This allows the user to adjust all the limit lines in a row, and is very useful when you need to adjust a mask with a number of limit lines. As far as I know, (at least) the Keysight network analyzers have this feature.