Merge pull request #969 from ra3xdh/968_fix

Fix simulation properties edition
ra3xdh · Sep 28, 2024 · f5b15fa · f5b15fa
2 parents 16d4e42 + 684b06a
commit f5b15fa
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/qucs/components/componentdialog.cpp b/qucs/components/componentdialog.cpp
@@ -1525,11 +1525,20 @@ void ComponentDialog::fillPropsFromTable()
     QString disp = prop->item(row, 2)->text();
     QString desc = prop->item(row, 3)->text();
     bool display = (disp == tr("yes"));
-    if (row < Comp->Props.count()) {
-      auto pp = Comp->Props[row];
-      if (pp->Name == name) {
+    if (compIsSimulation) {
+      // Get property by name
+      auto pp = Comp->getProperty(name);
+      if (pp != nullptr) {
         updateProperty(pp,value,display);
       }
+    } else {
+      // Other components may have properties with duplicate names
+      if (row < Comp->Props.count()) {
+        auto pp = Comp->Props[row];
+        if (pp->Name == name) {
+          updateProperty(pp,value,display);
+        }
+      }
     }
   }
 }