Skip to content

Commit

Permalink
Merge pull request #955 from ra3xdh/release/24.3.2
Browse files Browse the repository at this point in the history
Release/24.3.2
  • Loading branch information
ra3xdh authored Sep 23, 2024
2 parents e687757 + 4dd6f10 commit 4a9a5a4
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 8 deletions.
7 changes: 7 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# Qucs-S 24.3.2

## Bugfixes

* Fixed editing of File-type properties #948
* Implemented @model[param] syntax recognition for Parameter sweep #948

# Qucs-S 24.3.1

## Packaging
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
24.3.1
24.3.2
12 changes: 8 additions & 4 deletions qucs/components/componentdialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1096,9 +1096,9 @@ void ComponentDialog::slotBrowseFile()
s = file.fileName();
}
edit->setText(s);
int row = prop->currentRow();
prop->item(row,1)->setText(s);
}
/* FIX
prop->currentItem()->setText(1, s); */
}

// -------------------------------------------------------------------------
Expand Down Expand Up @@ -1525,8 +1525,12 @@ void ComponentDialog::fillPropsFromTable()
QString disp = prop->item(row, 2)->text();
QString desc = prop->item(row, 3)->text();
bool display = (disp == tr("yes"));
auto pp = Comp->getProperty(name);
updateProperty(pp,value,display);
if (row < Comp->Props.count()) {
auto pp = Comp->Props[row];
if (pp->Name == name) {
updateProperty(pp,value,display);
}
}
}
}

Expand Down
8 changes: 5 additions & 3 deletions qucs/components/param_sweep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,13 @@ QString Param_Sweep::getNgspiceBeforeSim(QString sim, int lvl)

if (step_var == "temp" || step_var == "temper") temper_sweep = true;

if (temper_sweep) {
if (temper_sweep) { // Sweep temperature
s += QString("option temp = $%1_act%2").arg(step_var).arg(nline_char);
} else if (compfound) {
} else if (compfound) { // Sweep device
s += QString("alter %1 = $%2_act%3").arg(par).arg(step_var).arg(nline_char);
} else {
} else if (par.startsWith("@")) { // Sweep model
s += QString("altermod %1 = $%2_act%3").arg(par).arg(step_var).arg(nline_char);
} else { // Sweep .PARAM variable
s += QString("alterparam %1 = $%2_act%3reset%3").arg(par).arg(step_var).arg(nline_char);
}
}
Expand Down

0 comments on commit 4a9a5a4

Please sign in to comment.