Check for duplicate names when supplying character literals #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
commented
Oct 25, 2024
| @@ -18,36 +18,12 @@ vars_select_eval <- function(vars, | |||
| return(pos) | |||
| } | |||
|
|
|||
| uniquely_named <- uniquely_named %||% is.data.frame(data) | |||
|
|
|||
| if (!is_symbolic(wrapped)) { | |||
There was a problem hiding this comment.
I removed this early exit for literals so that all inputs go through the same path via the tidyselect interpreter.
There was a problem hiding this comment.
Seems like a very good idea for consistency
| @@ -301,11 +277,6 @@ chr_as_locations <- function(x, vars, call = caller_env(), arg = NULL) { | |||
| set_names(out, names(x)) | |||
| } | |||
|
|
|||
| as_indices <- function(x, vars, strict = TRUE, call) { | |||
| internal <- data_mask$.__tidyselect__.$internal | ||
|
|
||
| if (internal$uniquely_named && is_character(expr)) { | ||
| # Since tidyselect allows repairing data frames with duplicate names by |
There was a problem hiding this comment.
Hopefully this comment is clear 😬
DavisVaughan
approved these changes
Oct 25, 2024
| vars_split <- vctrs::vec_split(seq_along(vars), vars) | ||
|
|
||
| # Mark data duplicates so we can fail instead of disambiguating them | ||
| # when renaming | ||
| uniquely_named <- uniquely_named %||% is.data.frame(data) |
There was a problem hiding this comment.
Interesting, I didn't know the uniqueness check behavior depended on whether or not the input was a data frame vs like a named list or named character vector
| @@ -18,36 +18,12 @@ vars_select_eval <- function(vars, | |||
| return(pos) | |||
| } | |||
|
|
|||
| uniquely_named <- uniquely_named %||% is.data.frame(data) | |||
|
|
|||
| if (!is_symbolic(wrapped)) { | |||
There was a problem hiding this comment.
Seems like a very good idea for consistency
lionel-
force-pushed
the
bugfix/duplicate-check
branch
from
1d54d2d to
9f75fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #346.