Allow *=?param parameter specifications

That apply to all packages.
r-lib · Feb 7, 2024 · fcdfa2b · fcdfa2b
1 parent 46bf395
commit fcdfa2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/parse-remotes.R b/R/parse-remotes.R
@@ -246,7 +246,7 @@ parse_pkg_ref <- function(ref, remote_types = NULL, ...) {
 
 param_rx <- function() {
   paste0(
-    "(?:(?<package>", package_name_rx(), ")=)",
+    "(?:(?<package>", package_name_rx(), "|[*])=)",
     "$"
   )
 }

diff --git a/R/resolution.R b/R/resolution.R
@@ -275,7 +275,7 @@ res_push <- function(self, private, ..., direct, .list = .list) {
   params <- new[new_types == "param"]
   new <- new[new_types != "param"]
 
-  if (length(params)) {
+  if (length(params) + length(private$params)) {
     private$params <- c(private$params, params)
     update_params(self, private, private$params)
   }
@@ -506,7 +506,7 @@ resolve_remote <- function(remote, direct, config, cache, dependencies,
 
 update_params <- function(self, private, params) {
   for (par in params) {
-    if (par$package == "" && length(self$result$params)) {
+    if (par$package %in% c("", "*") && length(self$result$params)) {
       self$result$params <- lapply(self$result$params, function(p) {
         p[names(par$params)] <- par$params
         p
-Original file line number
+Diff line change
@@ Expand Up / @@ -246,7 +246,7 @@ parse_pkg_ref <- function(ref, remote_types = NULL, ...) { @@
     param_rx <- function() {
       paste0(
-        "(?:(?<package>", package_name_rx(), ")=)",
+        "(?:(?<package>", package_name_rx(), "|[*])=)",
         "$"
       )
     }
@@ Expand Down @@