Skip to content

Commit

Permalink
Use check = FALSE for extra metadata
Browse files Browse the repository at this point in the history
No need to check for validity, and also, we need
this to embed in pak, because the S3 check methods
do not work there.
  • Loading branch information
gaborcsardi committed Nov 24, 2023
1 parent dd5b3e5 commit 9449da4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ Imports:
stats,
utils,
zip (>= 2.3.0)
Remotes:
r-lib/desc
Suggests:
asciicast (>= 2.2.0.9000),
covr,
Expand Down
5 changes: 4 additions & 1 deletion R/install-binary.R
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ add_metadata <- function(pkg_path, metadata) {
source_desc <- file.path(pkg_path, "DESCRIPTION")
binary_desc <- file.path(pkg_path, "Meta", "package.rds")
if (file.exists(source_desc)) {
do.call(desc::desc_set, c(as.list(metadata), list(file = source_desc)))
do.call(
desc::desc_set,
c(as.list(metadata), list(file = source_desc, check = FALSE))
)
}

if (file.exists(binary_desc)) {
Expand Down

0 comments on commit 9449da4

Please sign in to comment.