Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Enhances S3 methods more selectively #2690

Closed
wants to merge 2 commits into from

Conversation

MichaelChirico
Copy link
Collaborator

Cribbing this from Rdatatable/data.table#6589 -- our current approach always tries requireNamespace(). IMO it's better to avoid that for the very-weak Enhances dependency if we can.

@MichaelChirico
Copy link
Collaborator Author

Actually, IIUC we can fully drop this section of .onLoad() in favor of a NAMESPACE directive, however, I'm not sure how to generate the directive with {roxygen2}. I'll return to this when I have more time.

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 4, 2024

Isn't there @rawNamespace for manual entries?

@MichaelChirico
Copy link
Collaborator Author

Right, I'm just not sure if it's supported directly or we need to resort to @rawNamespace.

@olivroy olivroy closed this in #2693 Dec 4, 2024
@olivroy olivroy deleted the s3-enhances-require branch December 4, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants