Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if vigilant workflow is working as expected #2239

Closed
wants to merge 3 commits into from

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #2239 (1633041) into main (8f8f151) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 1633041 differs from pull request most recent head bce2ba4. Consider uploading reports for the commit bce2ba4 to get more accurate results

@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         114      114              
  Lines        5247     5215      -32     
==========================================
- Hits         5229     5197      -32     
  Misses         18       18              
Files Coverage Δ
R/lint.R 98.79% <100.00%> (-0.11%) ⬇️

@IndrajeetPatil
Copy link
Collaborator Author

Ignore the lint workflow failure, that's deliberate.

The relevant thing to note is that this workflow doesn't fail even if there is a warning in tests:

| F W  S  OK | Context|          0 | testthat                                                       [ FAIL 0 | WARN 1 | SKIP 0 | PASS 5149 ]

[ FAIL 0 | WARN 1 | SKIP 0 | PASS 5149 ]

@IndrajeetPatil IndrajeetPatil deleted the check-vigilant-workflow-working branch January 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants