Support lapply(x, seq)

r-lib · Jun 22, 2024 · 396a239 · 396a239
1 parent 69b4ad2
commit 396a239
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/R/seq_linter.R b/R/seq_linter.R
@@ -76,9 +76,10 @@ seq_linter <- function() {
     ]
   ")
 
-  map_funcs <-  c("sapply", "lapply", "map")
+  map_funcs <- c("sapply", "lapply", "map")
+  seq_funcs <- xp_text_in_table(c("seq_len", "seq"))
   sequence_xpath <- glue("
-    parent::expr[following-sibling::expr/SYMBOL[text() = 'seq_len']]
+    parent::expr[following-sibling::expr/SYMBOL[ {seq_funcs} ]]
     /parent::expr/parent::expr[
       expr/SYMBOL_FUNCTION_CALL[text() = 'unlist']
     ]"

diff --git a/tests/testthat/test-seq_linter.R b/tests/testthat/test-seq_linter.R
@@ -133,6 +133,12 @@ test_that("finds potential sequence() replacements", {
     linter
   )
 
+  expect_lint(
+    "unlist(lapply(x, seq))",
+    lint_msg,
+    linter
+  )
+
   # Even for prefixed purrr:: calls
   expect_lint(
     "unlist(purrr::map(x, seq_len))",