Make later_fd() tests more robust
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jcheng5 sorry I missed this - these tests have simply never failed before (including during many rhub runs), but is creating some noise on CRAN.
It's only the test without the 0.2 secs sleep before the
run_now()that's failing. Technically, it's possible that thelater_fd()thread hasn't sent the callback for execution yet.As the other tests in that section are passing, I'm pretty sure it's just a timing issue.
I've also increased the sleeps to at least 0.2secs in a couple of other places to be safer.
EDIT: even better - switched all the sleeps to blocking
run_now(1)where possible.The CRAN check error seems to have solved itself within a few hours, but these more robust tests will prevent it coming back.