Improve error messages

r-lib · Sep 22, 2022 · a1d747a · a1d747a
1 parent 5c3ca20
commit a1d747a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/R/inline.R b/R/inline.R
@@ -299,12 +299,12 @@ make_cmd_transformer <- function(values) {
     } else {
       expr <- parse(text = code, keep.source = FALSE) %??%
         cli_error(paste(
-          "Error while parsing cli {.code {{}}} expression:",
+          "Could not parse cli {.code {{}}} expression:",
           "{.code {abbrev(code, 20)}}."
         ))
       res <- eval(expr, envir = envir) %??%
         cli_error(paste(
-          "Error while evaluating cli {.code {{}}} expression:",
+          "Could not evaluate cli {.code {{}}} expression:",
           "{.code {abbrev(code, 20)}}."
         ))
 

diff --git a/tests/testthat/_snaps/inline-2.md b/tests/testthat/_snaps/inline-2.md
@@ -394,7 +394,7 @@
       cli_text("xx {1 + 'a'} yy")
     Condition
       Error:
-      ! Error while evaluating cli `{}` expression: `1 + 'a'`.
+      ! Could not evaluate cli `{}` expression: `1 + 'a'`.
       Caused by error:
       ! non-numeric argument to binary operator
 
diff --git a/tests/testthat/_snaps/new-r/inline-2.md b/tests/testthat/_snaps/new-r/inline-2.md
@@ -4,7 +4,7 @@
       cli_text("xx {__cannot-parse-this__} yy")
     Condition
       Error:
-      ! Error while parsing cli `{}` expression: `__cannot-parse-th...`.
+      ! Could not parse cli `{}` expression: `__cannot-parse-th...`.
       Caused by error:
       ! <text>:1:2: unexpected input
       1: __

diff --git a/tests/testthat/_snaps/progress-along.md b/tests/testthat/_snaps/progress-along.md
@@ -45,7 +45,7 @@
       cli_with_ticks(fun())
     Condition
       Warning in `value[[3L]]()`:
-      cli progress bar update failed: ! Error while evaluating cli `{}` expression: `1+''`.
+      cli progress bar update failed: ! Could not evaluate cli `{}` expression: `1+''`.
       Caused by error in `1 + ""`:
       ! non-numeric argument to binary operator
     Output