Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean pkgdown website on releases #735

Closed
wants to merge 1 commit into from
Closed

Clean pkgdown website on releases #735

wants to merge 1 commit into from

Conversation

Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Jun 8, 2023

This avoid keeping obsolete vignettes that have been deleted from the main branch. I believe it's safe and a good trade-off to clean on releases.

Related: #484

I have added the following comment in my internal workflow and can copy it here if you believe that'd be helpful:

# We clean on releases because we want to remove old vignettes, 
# figures, etc. that have been deleted from the `main` branch.
# But we clean ONLY on releases because we want to be able to keep
# both the 'stable' and 'dev' websites.
# Also discussed in https://github.com/r-lib/actions/issues/484

This avoid keeping obsolete vignettes that have been deleted from the main branch
@codecov-commenter
Copy link

Codecov Report

Merging #735 (494d68a) into v2-branch (5ab5909) will not change coverage.
The diff coverage is n/a.

❗ Current head 494d68a differs from pull request most recent head 722bdba. Consider uploading reports for the commit 722bdba to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #735   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

@gaborcsardi
Copy link
Member

That's a good idea, but if you have also have a pkgdown site for the dev version of the package, that is also cleaned up, unfortunately.

@Bisaloo
Copy link
Contributor Author

Bisaloo commented Jun 12, 2023

Ah yes, I assumed the case where the release is created immediately and it is perfectly in sync with main. In this case, it makes sense to not have a dev version.

One potential solution would be to trigger again the workflow on HEAD if it was triggered by a release. But it might start to be a little bit too involved 🤔

@Bisaloo Bisaloo closed this by deleting the head repository Jul 16, 2023
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants