prefer inherits() to string-comparison

r-box · Dec 31, 2023 · 0c7fd28 · 0c7fd28
1 parent b88116e
commit 0c7fd28
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/R/boxr__internal_dir_comparison.R b/R/boxr__internal_dir_comparison.R
@@ -211,7 +211,7 @@ box_dir_diff <- function(dir_id = box_getwd(), local_dir = getwd(), load = "up",
     to_update <- behind <- data.frame()
   }
 
-  if (class(absent) != "data.frame")
+  if (!inherits(absent, "data.frame"))
     absent <- data.frame()
 
   # The final list to output

diff --git a/R/boxr__internal_get.R b/R/boxr__internal_get.R
@@ -1,8 +1,8 @@
 handle_file_id <- function(obj) {
-  if (class(obj) == "boxr_file_reference") {
+  if (inherits(obj, "boxr_file_reference")) {
     # If the user's submitted a file reference object, extract the id for them
     file_id <- obj$id 
-  } else if (class(obj) == "boxr_object_list") {
+  } else if (inherits(obj, "boxr_object_list")) {
     # If the user's submitted a list of objects, extract the id from the first,
     # and emit a message so they know what's up
     if(length(obj) > 1)