This repository has been archived by the owner on Nov 16, 2018. It is now read-only.
Support custom icons #120
Open
Support custom icons #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced CSS files with those from eonasdan-bootstrap-datetimepicker for better feature parity Updated Examples to use eonasdan-bootstrap-datetimepicker CSS
…and fixed/removed positioning styles etiher included in CSS or not needed
Markup cleanup
Fixes for tests
This file belongs in a different branch
…rap-datetimepicker does: - defaults to glyphicons - pass in optional icons object to replace some/all of the icons - unit tests
|
It's a pity this one is not merged. I'm using bootstrap 4 where glyphicons are deprecated. This PR would make a switch to FA much simpler. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.