Add Dockerfile and Makefile to create ocr-d dockerimage

[joschrew]

This PR adds a Dockerfile and Makefile to create a dockerimage for this processor. Ideally all OCR-D processors offer the same way to create an image for them, which is currently missing in this repo.
I am not sure though if this is desired here as well, because it seems to me dinglehopper has slightly other layout as a "normal" ocr-d processor has. Dinglehopper seems also to be supposed to be used detached from ocr-d. That's why I created a draft PR at first.

[mikegerber]

This PR adds a Dockerfile and Makefile to create a dockerimage for this processor. Ideally all OCR-D processors offer the same way to create an image for them, which is currently missing in this repo.

I'm all for it, have just been waiting for some kind of OCR-D/ocrd_all "standard" to follow.

I am not sure though if this is desired here as well,

Frankly, I'm not a big fan of "Makefiles everywhere", but I also don't see any better solution, so that's OK :) Containerization is definitely wanted.

because it seems to me dinglehopper has slightly other layout as a "normal" ocr-d processor has.

Could you elaborate on that? Maybe we can clear it up.

Dinglehopper seems also to be supposed to be used detached from ocr-d. That's why I created a draft PR at first.

dinglehopper has two CLIs: dinglehopper is standalone, ocrd-dinglehopper is the OCR-D CLI. Nothing special about it 😄

[mikegerber]

Leaving it a "Request changes" for now, but it's only small stuff.

[mikegerber]

Another question: Should dinglehopper's CI build the image or will that be done by e.g. ocrd_all?

[bertsky]

Another question: Should dinglehopper's CI build the image or will that be done by e.g. ocrd_all?

Preferably via local CD here.

See here for an example GHA CD which pushes to both Dockerhub and GHCR. (All it takes is to set up a DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD secret in your repo.)

[mikegerber]

Another question: Should dinglehopper's CI build the image or will that be done by e.g. ocrd_all?
See here for an example GHA CD which pushes to both Dockerhub and GHCR. (All it takes is to set up a DOCKERHUB_USERNAME and DOCKERHUB_PASSWORD secret in your repo.)

I've opened #121.

Any reasoning behind pushing to two container registries?

[mikegerber]

So, then all that's left to clear up is:

because it seems to me dinglehopper has slightly other layout as a "normal" ocr-d processor has.

[joschrew]

Thanks both of you for extending this PR. I'll mark it ready to merge then.

So, then all that's left to clear up is:

Sorry for the confusion. The project layout is totally fine and working for ocr-d purposes, it just made me wonder if this PR would be accepted. My intention was simply to not make a PR and expecting it to be merged with stuff which may not be wanted by the maintainer (you). But I see it's ok with you.

[mikegerber]

Thanks both of you for extending this PR. I'll mark it ready to merge then.

So, then all that's left to clear up is:

Sorry for the confusion. The project layout is totally fine and working for ocr-d purposes, it just made me wonder if this PR would be accepted. My intention was simply to not make a PR and expecting it to be merged with stuff which may not be wanted by the maintainer (you). But I see it's ok with you.

Alright! I'll give the Docker image a spin and if it looks good, I'll merge. (I opened a separate issue for the CD builds.)

I might do something slightly differently (e.g. CMD), because honestly, I'm not bound by OCR-D specs in all details and I see no harm.

[mikegerber]

I might do something slightly differently (e.g. CMD), because honestly, I'm not bound by OCR-D specs in all details and I see no harm.

In the current state it executes ocrd btw (probably from the core image).

[mikegerber]

I tested the built image superficially, looks OK!

[bertsky]

In the current state it executes ocrd btw (probably from the core image).

Yes, that's inherited from the previous stage. I don't know why we put the ocrd --help in there. It used to be just bash (inherited from the original stage, ubuntu).